Fix symbols duplication on keyboard paste hotkeys#3047
Closed
Andrei Salavei (ASalavei) wants to merge 16 commits into
Closed
Fix symbols duplication on keyboard paste hotkeys#3047Andrei Salavei (ASalavei) wants to merge 16 commits into
Andrei Salavei (ASalavei) wants to merge 16 commits into
Conversation
# Conflicts: # compose/ui/ui/src/iosMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.ios.kt # compose/ui/ui/src/iosMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.ios.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove keyboard events handling from the text input view.
Skip edit menu events if there is an active key press detected.
Add logic that simulates key up events for started events with detached views - these events are not propagated by iOS.
Add ability to test key presses on simulator environment.
Add tests for key presses and text edit operations with hotkeys.
Fixes https://youtrack.jetbrains.com/issue/CMP-8355/iOS-btf2-duplicate-symbols-after-paste-via-keyboard
QA Notes
Issue where Compose may duplicate key events during text input
onKeyEventmodifier for BoxonKeyEventregisters single event for every keystrokeFix symbols duplication on keyboard paste hotkeys
Issue where the Compose does not receive key events when initially created.
onKeyEventon the first application screenonKeyEventshould handle key eventsRelease Notes
Fixes - iOS