Skip to content

Fix DatePickerDialog confirmButton and dismissButton inconsistent position for platforms by impl of skiko#3048

Merged
Ivan Matkov (MatkovIvan) merged 1 commit into
JetBrains:jb-mainfrom
shawshuai:bugfix/CMP-10091-datepickerdialog-button-order-issue-on-skiko
May 18, 2026
Merged

Fix DatePickerDialog confirmButton and dismissButton inconsistent position for platforms by impl of skiko#3048
Ivan Matkov (MatkovIvan) merged 1 commit into
JetBrains:jb-mainfrom
shawshuai:bugfix/CMP-10091-datepickerdialog-button-order-issue-on-skiko

Conversation

@shawshuai

@shawshuai shawshuai (shawshuai) commented May 14, 2026

Copy link
Copy Markdown

Fix DatePickerDialog confirmButton and dismissButton at inconsistent position in skiko implementation (on iOS, JVM desktop, JS and Wasm)
Following the upsteam androidx/androidx's fix for Android androidx@5e5fbcc

Fixes https://youtrack.jetbrains.com/issue/CMP-10091/iOS-Material3-dialogs-render-confirmButton-and-dismissButton-in-inconsistent-positions

Testing

Code snippits

    <string name="common_action_ok">OK</string>
    <string name="common_action_cancel">Cancel</string>
DatePickerDialog(
            onDismissRequest = { /* close */ },
            confirmButton = {
                TextButton(onClick = { /* close */ }) {
                    Text(stringResource(Res.string.common_action_ok))
                }
            },
            dismissButton = {
                TextButton(onClick = { /* close */ }) {
                    Text(stringResource(Res.string.common_action_cancel))
                }
            }
        ) {
            DatePicker(
                state = datePickerState
            )
        }

Steps

  1. Made the modifications and published to mavenLocal
  2. Change the project depends on this libs to refer version 9999.0.0-SNAPSHOT
  3. Build and run project supported by skiko (iOS, JVM on macOS, Kotlin/JS and Kotlin/wasm)
  4. Confirm the confirmButton and dismissButton in DatePickerDialog on these targets align to the Android (under LTR language, dismissButton at left, confirmButton at right )

Release Notes

Fixes - Multiple Platforms

  • Fix DatePickerDialog's confirmButton and dismissButton display order on iOS, Desktop, Kotlin/JS and Kotlin/Wasm not consistent with Material Design guidance

@MatkovIvan Ivan Matkov (MatkovIvan) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatkovIvan Ivan Matkov (MatkovIvan) merged commit 05eb3e1 into JetBrains:jb-main May 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants