Merged
Conversation
ASalavei
approved these changes
Apr 7, 2026
Contributor
ASalavei
left a comment
There was a problem hiding this comment.
LGTM. Couple of notes:
- The measurement looks accurate, however it must be done with release mode and disabled debugger.
- Fist launch much slower then the following launches (cold vs hot launch) - this must be considered during launch tests.
- iOS device behaves differently with attached/detached cable. To ensure that the numbers measured correctly, I would recommend to do several launches of the app not from XCode, but with the standard way - by tapping an icon in both: cold and hot start.
- Would be great to collect these metrics on a regular bases from one of our apps (KotlinConf?)
Contributor
Author
Sure. The purpose of the benchmarks is to be installed in the performance infrastructure to catch regressions/improvements. We will take into account these notes (/cc @PavelPunegov)
I don't think that real apps are ok to add to the benchmarking system, though I agree that we could measure similar way startup of them separately (as an additional task). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new
startupbenchmark mode that measures application startup performance, from process start to the first frame and beyond.Fixes CMP-9700
Release Notes
N/A