Make agents-mcp support KMP targets#756
Merged
Merged
Conversation
kpavlov
added
the
refactoring
Contributor
Author
|
Project compiles with Kotlin 2.2.0+ |
kpavlov
changed the title
kpavlov
changed the title
Qodana for JVM833 new problems were found
@@ Code coverage @@
+ 67% total lines covered
11273 lines analyzed, 7580 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
9 tasks
Qodana for JVM870 new problems were found
@@ Code coverage @@
+ 67% total lines covered
11681 lines analyzed, 7922 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
kpavlov
force-pushed
the
kpavlov/agents-mcp-kmp
branch
from
01db1a7 to
e11de91
Compare
## Changes - Moved reusable implementations (e.g., `McpToolRegistryProvider`, `McpTool`) to `commonMain`. - Updated Gradle configurations to align with Multiplatform support. - Adjusted platform-specific implementations where necessary. - Improved test structure using shared test utilities.
## Motivation and Context To streamline Android and Native dependencies and fix Ktor CIO dependency leaking to iOS and Android. - Added Android support for multiple modules, including Android-specific implementations for coroutine dispatchers. - Removed CIO engine from common dependencies (KG-315 / #710) - Configured Kotlin/JS targets with npm instead of yarn to minimize build dependencies in `gradle.properties`. - Integrated `google()` repository and Android Gradle Plugin setup (`com.android.library`) in build scripts. - Updated dependencies (`android-tools-gradle`, `ktor-client-cio`) and Gradle plugin versions. - Minor refactor in `KtorIntegrationExample` (OpenTelemetry exporter setup). - Updated CONTRIBUTING.md to include note on Node.js requirement for Kotlin/JS targets. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [x] Refactoring #### Checklist - [ ] The pull request has a description of the proposed change - [ ] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [ ] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
#724) ## Motivation and Context To speed up the build ## Changes - Update Qodana action to `v2025.2` and enable caching on default branch - Added `kotlin.native.ignoreDisabledTargets=true` to remove noise in logs --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [x] Refactoring - [x] CI configuration updates #### Checklist - [ ] The pull request has a description of the proposed change - [ ] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [ ] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
kpavlov
force-pushed
the
kpavlov/agents-mcp-kmp
branch
from
e11de91 to
6024a0a
Compare
- Bump MCP SDK to version `0.7.0`. - Split MCP dependencies into `mcp-client` and `mcp-server`. - Update Gradle configurations and test dependencies accordingly.
kpavlov
force-pushed
the
kpavlov/agents-mcp-kmp
branch
from
4874eb1 to
65ad4a3
Compare
devcrocod
approved these changes
Sep 12, 2025
Contributor
devcrocod
left a comment
devcrocod
left a comment
There was a problem hiding this comment.
👍
Please take a look at my little comments
Ololoshechkin
pushed a commit
that referenced
this pull request
Sep 12, 2025
## Motivation and Context To make McpTool cross-platform - KG-380 - [Slack thread](https://kotlinlang.slack.com/archives/C08SLB97W23/p1757126633769069) - Requires #764 ## Changes - Moved reusable implementations (e.g., `McpToolRegistryProvider`, `McpTool`) to `commonMain`. - Updated Gradle configurations to align with Multiplatform support. - Adjusted platform-specific implementations where necessary. - Improved test structure using shared test utilities. ## Breaking Changes - McpToolRegistryProvider.defaultStdioTransport is JVM-only and has to be imported (`import ai.koog.agents.mcp.defaultStdioTransport`) --- #### Type of the changes - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [x] Refactoring #### Checklist - [ ] The pull request has a description of the proposed change - [ ] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Sep 20, 2025
## Motivation and Context To make McpTool cross-platform - KG-380 - [Slack thread](https://kotlinlang.slack.com/archives/C08SLB97W23/p1757126633769069) - Requires JetBrains#764 ## Changes - Moved reusable implementations (e.g., `McpToolRegistryProvider`, `McpTool`) to `commonMain`. - Updated Gradle configurations to align with Multiplatform support. - Adjusted platform-specific implementations where necessary. - Improved test structure using shared test utilities. ## Breaking Changes - McpToolRegistryProvider.defaultStdioTransport is JVM-only and has to be imported (`import ai.koog.agents.mcp.defaultStdioTransport`) --- #### Type of the changes - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [x] Refactoring #### Checklist - [ ] The pull request has a description of the proposed change - [ ] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To make McpTool cross-platform
Changes
McpToolRegistryProvider,McpTool) tocommonMain.Breaking Changes
import ai.koog.agents.mcp.defaultStdioTransport)Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature