From 4d8633759f622df31d6571b593ab0369d1c8cd6e Mon Sep 17 00:00:00 2001 From: Artem Smirnov Date: Thu, 12 Mar 2026 13:28:57 +0100 Subject: [PATCH 01/23] Dokka: Small fixes in KDocs for the theme(). --- .../kotlin/org/jetbrains/letsPlot/themes/theme.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plot-api/src/commonMain/kotlin/org/jetbrains/letsPlot/themes/theme.kt b/plot-api/src/commonMain/kotlin/org/jetbrains/letsPlot/themes/theme.kt index a8740baae..0eb6caea4 100644 --- a/plot-api/src/commonMain/kotlin/org/jetbrains/letsPlot/themes/theme.kt +++ b/plot-api/src/commonMain/kotlin/org/jetbrains/letsPlot/themes/theme.kt @@ -181,11 +181,11 @@ import org.jetbrains.letsPlot.intern.filterNonNullValues * @param stripTextX Style settings for horizontal facet labels. * @param stripTextY Style settings for vertical facet labels. * @param stripSpacing Spacing between facet labels and the plotting area. - * @param stripSpacingX Spacing between facet labels and the plotting area in horizontal direction, inherited from ``stripSpacing``. - * @param stripSpacingY Spacing between facet labels and the plotting area in vertical direction, inherited from ``stripSpacing``. + * @param stripSpacingX Spacing between facet labels and the plotting area in horizontal direction, inherited from `stripSpacing`. + * @param stripSpacingY Spacing between facet labels and the plotting area in vertical direction, inherited from `stripSpacing`. * @param panelSpacing Spacing between panels in facets. - * @param panelSpacingX Spacing between panels in facets in horizontal direction, inherited from ``panelSpacing``. - * @param panelSpacingY Spacing between panels in facets in vertical direction, inherited from ``panelSpacing``. + * @param panelSpacingX Spacing between panels in facets in horizontal direction, inherited from `panelSpacing`. + * @param panelSpacingY Spacing between panels in facets in vertical direction, inherited from `panelSpacing`. * * @param axisTooltip Style settings for axes tooltips. * @param axisTooltipX Style settings for axes tooltips. From 8420c8dc4f87a3a833cca4c1bbc3b2bde0173657 Mon Sep 17 00:00:00 2001 From: Artem Smirnov Date: Thu, 12 Mar 2026 15:23:31 +0100 Subject: [PATCH 02/23] Writerside: Rename the 'Changelog' section on the 'What is new' page. --- Writerside/topics/whats_new.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Writerside/topics/whats_new.md b/Writerside/topics/whats_new.md index 80c93b879..39451f4f4 100644 --- a/Writerside/topics/whats_new.md +++ b/Writerside/topics/whats_new.md @@ -104,6 +104,6 @@ -## Change Log +## Changelog See [CHANGELOG.md](https://github.com/JetBrains/lets-plot-kotlin/blob/master/CHANGELOG.md) for other changes and fixes. \ No newline at end of file From cbd1b5bd01553002bc7214ce9f6e6fe0628cef7f Mon Sep 17 00:00:00 2001 From: Artem Smirnov Date: Thu, 12 Mar 2026 17:53:51 +0100 Subject: [PATCH 03/23] Writerside: API Reference page opened in the same tab. --- Writerside/cfg/static/custom.css | 8 ++++++++ Writerside/lpk.tree | 2 +- Writerside/source/in-head.html | 18 +++++++++++------- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/Writerside/cfg/static/custom.css b/Writerside/cfg/static/custom.css index c9522d841..e3f3357da 100644 --- a/Writerside/cfg/static/custom.css +++ b/Writerside/cfg/static/custom.css @@ -1,3 +1,11 @@ +/* Common */ + +ul li[data-toc-scroll='toc-api-reference'] a::after { + content: none; +} + +/* Named colors tables */ + div[data-tab-id="by-shade"] div.table>div { width: 100%; border: none; diff --git a/Writerside/lpk.tree b/Writerside/lpk.tree index e894fdc82..a619a4efa 100644 --- a/Writerside/lpk.tree +++ b/Writerside/lpk.tree @@ -7,7 +7,7 @@ start-page="get-started.md"> - + diff --git a/Writerside/source/in-head.html b/Writerside/source/in-head.html index 344154524..b52d4019c 100644 --- a/Writerside/source/in-head.html +++ b/Writerside/source/in-head.html @@ -2,22 +2,26 @@ document.addEventListener("DOMContentLoaded", onDOMContentLoaded); function onDOMContentLoaded() { - addGitHubLinkToHeader(); + whenLoaded("header .wh-header").then(addGitHubLinkToHeader); + whenLoaded("ul li[data-toc-scroll='toc-api-reference'] a").then(fixAPIReferenceTocLink); } - function addGitHubLinkToHeader() { + function addGitHubLinkToHeader(headerElem) { function createGitHubLink() { const gitHubLinkElem = document.createElement("a"); gitHubLinkElem.setAttribute("href", "https://github.com/JetBrains/lets-plot-kotlin"); gitHubLinkElem.setAttribute("id", "github-repo-link"); + gitHubLinkElem.setAttribute("target", "_blank"); return gitHubLinkElem; } - whenLoaded("header .wh-header").then((headerElem) => { - const switchersElem = headerElem.querySelector(".wh-header__switchers"); - const gitHubLinkElem = createGitHubLink(); - headerElem.insertBefore(gitHubLinkElem, switchersElem); - }); + const switchersElem = headerElem.querySelector(".wh-header__switchers"); + const gitHubLinkElem = createGitHubLink(); + headerElem.insertBefore(gitHubLinkElem, switchersElem); + } + + function fixAPIReferenceTocLink(linkElem) { + linkElem.removeAttribute("target"); } function whenLoaded(selector) { From e8f5691c09edf962b85337699eede7a71a6fcf78 Mon Sep 17 00:00:00 2001 From: Artem Smirnov Date: Thu, 12 Mar 2026 18:07:14 +0100 Subject: [PATCH 04/23] Writerside: Small fixes in the API Reference toc link. --- Writerside/source/in-head.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Writerside/source/in-head.html b/Writerside/source/in-head.html index b52d4019c..388e1af05 100644 --- a/Writerside/source/in-head.html +++ b/Writerside/source/in-head.html @@ -22,6 +22,8 @@ function fixAPIReferenceTocLink(linkElem) { linkElem.removeAttribute("target"); + linkElem.classList.remove("toc-item--external"); + linkElem.dataset.test = linkElem.dataset.test.replace("external-link", "internal-link"); } function whenLoaded(selector) { From ba2bcb26a6f9a3b0673ab60d4629895e7dbb398e Mon Sep 17 00:00:00 2001 From: Artem Smirnov Date: Thu, 12 Mar 2026 18:56:16 +0100 Subject: [PATCH 05/23] Writerside: Logo link also become internal. --- Writerside/source/in-head.html | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/Writerside/source/in-head.html b/Writerside/source/in-head.html index 388e1af05..cf282a467 100644 --- a/Writerside/source/in-head.html +++ b/Writerside/source/in-head.html @@ -2,10 +2,15 @@ document.addEventListener("DOMContentLoaded", onDOMContentLoaded); function onDOMContentLoaded() { + whenLoaded("header .wh-header a.wh-header__link").then(fixLogoLink); whenLoaded("header .wh-header").then(addGitHubLinkToHeader); whenLoaded("ul li[data-toc-scroll='toc-api-reference'] a").then(fixAPIReferenceTocLink); } + function fixLogoLink(linkElem) { + makeLinkInternal(linkElem); + } + function addGitHubLinkToHeader(headerElem) { function createGitHubLink() { const gitHubLinkElem = document.createElement("a"); @@ -21,9 +26,8 @@ } function fixAPIReferenceTocLink(linkElem) { - linkElem.removeAttribute("target"); - linkElem.classList.remove("toc-item--external"); - linkElem.dataset.test = linkElem.dataset.test.replace("external-link", "internal-link"); + const isInternal = makeLinkInternal(linkElem); + if (isInternal) linkElem.classList.remove("toc-item--external"); } function whenLoaded(selector) { @@ -43,6 +47,14 @@ } }); } + + function makeLinkInternal(linkElem) { + const href = linkElem.getAttribute("href"); + if (!href.startsWith("https://lets-plot.org")) return false; + linkElem.removeAttribute("target"); + linkElem.dataset.test = linkElem.dataset.test.replace("external-link", "internal-link"); + return true; + }