Skip to content

Fix Repository Pagination to Prevent Rate Limit Exhaustion #8250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iqb430 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −39
Open

Fix Repository Pagination to Prevent Rate Limit Exhaustion #8250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 1 addition & 39 deletions lib/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,7 +1415,7 @@ async function fetchReposUncached(
options: FetchOptions
): Promise<GitHubRepo[]> {
const firstPageRes = await fetchWithRetry(
`${GITHUB_REST_URL}/users/${encodedUsername}/repos?per_page=100&page=1&sort=pushed`,
`${GITHUB_REST_URL}/users/${encodedUsername}/repos?per_page=100&sort=pushed`,
{
headers: getHeaders(options.token),
cache: 'no-store',
Expand All @@ -1434,44 +1434,6 @@ async function fetchReposUncached(
const firstPageRepos = (await firstPageRes.json()) as GitHubRepo[];
const allRepos: GitHubRepo[] = firstPageRepos.map(sanitizeRepo);

const MAX_PAGES = Number(process.env.GITHUB_MAX_PAGES ?? '3');

if (firstPageRepos.length === 100) {
const remainingPages = Array.from({ length: MAX_PAGES - 1 }, (_, i) => i + 2);

const responses = await Promise.all(
remainingPages.map((page) =>
fetchWithRetry(
`${GITHUB_REST_URL}/users/${encodedUsername}/repos?per_page=100&page=${page}&sort=pushed`,
{
headers: getHeaders(options.token),
cache: 'no-store',
signal: options.signal,
},
0,
undefined,
options.token
)
)
);

const pagesRepos = await Promise.all(
responses.map(async (response) => {
if (!response.ok) {
throwIfRateLimited(response);
throw new Error(`GitHub REST API error: ${response.status}`);
}

const repos = (await response.json()) as GitHubRepo[];
return repos.map(sanitizeRepo);
})
);

for (const repos of pagesRepos) {
allRepos.push(...repos);
}
}

if (!options.bypassCache) await reposCache.set(key, allRepos, GITHUB_CACHE_TTL_MS);
return allRepos;
}
Expand Down
Loading