Alphabetically Sort SOCIALS List for Improved User Experience#8270
Alphabetically Sort SOCIALS List for Improved User Experience#8270pisum-sativum wants to merge 4 commits into
Conversation
…nt timeout on large repos
|
@pisum-sativum is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR addresses issue #6501 by ensuring that the SOCIALS list is sorted alphabetically, making it easier for users to find their desired platform. This aligns with previous decisions aimed at improving user experience, such as fixing theme rendering based on system preferences and ensuring social URLs are correctly formatted. Thank you for your contribution, and I look forward to your updates! |
retenta-bot
Bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the generator UI’s socials selection experience by exporting the SOCIALS registry in alphabetical order, making the platform grid easier to scan.
Changes:
- Alphabetically sorts the exported
SOCIALSarray byname. - Adjusts
MAX_ACTION_PAGESin CI analytics fetching (note: unrelated to the PR’s stated scope).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/generator/data/socials.ts | Sorts the exported socials registry alphabetically to improve UI scanning. |
| services/github/ci-analytics.ts | Changes pagination limit for GitHub Actions analytics fetching (scope mismatch with PR goal). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const GITHUB_REST_URL = 'https://api.github.com'; | ||
| const MAX_REPO_PAGES = 2; | ||
| const MAX_ACTION_PAGES = 2; | ||
| const MAX_ACTION_PAGES = 1; | ||
| const MAX_FETCH_TARGETS = 5; |
| placeholder: 'e.g. https://huggingface.co/yourname', | ||
| }, | ||
| ]; | ||
| ].sort((a, b) => a.name.localeCompare(b.name)); |
| placeholder: 'e.g. https://huggingface.co/yourname', | ||
| }, | ||
| ]; | ||
| ].sort((a, b) => a.name.localeCompare(b.name)); |
github-actions
Bot
added
the
status:blocked
|
@JhaSourav07 @Aamod007 I have done the necessary changes kindly check and merge with appropriate labels. |
github-actions
Bot
removed
the
status:blocked
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
added
level:intermediate
Aamod007
left a comment
Aamod007
left a comment
There was a problem hiding this comment.
Thanks for adding alphabetical sorting to the SOCIALS list! This is a great user experience improvement.
However, it looks like this PR includes an unrelated change to \services/github/ci-analytics.ts.
To fix this, please revert the changes to \ci-analytics.ts\ using \git checkout\ or \git restore\ so that this PR is focused entirely on the socials sorting.
Looking forward to getting this merged once the branch is cleaned up!
Label Justification:
- \level:intermediate: Assigned based on 2 files changed.
- \ ype:feature: Improves the UI by organizing the socials list alphabetically.
- \mentor:Aamod007: Assigned as required.
Description
Fixes #6501
Automatically sorts the
SOCIALSlist alphabetically by platform name before it is exported. When this list is mapped over to render the UI selection grid, the alphabetical sorting makes it significantly easier for users to quickly scan and find their desired platform (e.g., 'CodePen' or 'Snapchat') without having to read through the entire list manually.Pillar
Visual Preview
(No visual changes to the design itself, but the dropdown order of socials is now alphabetized)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.