Skip to content

Commit 2b59d6b

Browse files
committed
fix waiting logic and comments
1 parent 038f0a0 commit 2b59d6b

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

zygisk/src/main/cpp/ipc_bridge.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ lsplant::ScopedLocalRef<jobject> IPCBridge::RequestSystemServerBinder(
307307
auto service_name = lsplant::ScopedLocalRef(env, env->NewStringUTF(bridgeServiceName.data()));
308308
lsplant::ScopedLocalRef<jobject> binder = {env, nullptr};
309309

310-
// The system_server might start its services slightly after Zygisk injects us.
310+
// The daemon might start its bridge service slightly after `system_server` specialization.
311311
// We retry a few times to give it a chance to register.
312312
const int max_retry = 10;
313313
for (int i = 0; i < max_retry; ++i) {
@@ -317,11 +317,9 @@ lsplant::ScopedLocalRef<jobject> IPCBridge::RequestSystemServerBinder(
317317
LOGI("Got system server binder via {} on attempt {}.", bridgeServiceName.data(), i + 1);
318318
return binder;
319319
}
320-
if (i < 2) {
321-
LOGW("Failed to get system server binder via {}, will retry in 1 second...",
322-
bridgeServiceName.data());
323-
std::this_thread::sleep_for(std::chrono::seconds(1));
324-
}
320+
LOGW("Failed to get system server binder via {}, will retry in 1 second...",
321+
bridgeServiceName.data());
322+
std::this_thread::sleep_for(std::chrono::seconds(1));
325323
}
326324

327325
LOGE("Failed to get system server binder after {} attempts. Aborting.", max_retry);

0 commit comments

Comments
 (0)