Skip to content

Fix Picocli ProGuard rules to prevent runtime crashes #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingMatrix merged 2 commits into from
Apr 8, 2026
Merged

Fix Picocli ProGuard rules to prevent runtime crashes #645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e267e15
Fix Picocli ProGuard rules to prevent runtime crashes
AnatolyJacobs Apr 8, 2026
ef4e29a
Resolve Picocli InitializationException in release builds
JingMatrix Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions daemon/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,30 @@
-keepclasseswithmembers class org.matrix.vector.daemon.Cli {
public static void main(java.lang.String[]);
}


# Keep IPC data models intact so Gson serializes the correct JSON keys
-keep class org.matrix.vector.daemon.CliRequest { *; }
-keep class org.matrix.vector.daemon.CliResponse { *; }

# Preserve annotations, generic signatures, and inner classes (critical for picocli reflection)
-keepattributes *Annotation*, Signature, InnerClasses, EnclosingMethod

# Keep internal Picocli classes required for `mixinStandardHelpOptions = true`
-keep class picocli.CommandLine$AutoHelpMixin { *; }
-keep class picocli.CommandLine$HelpCommand { *; }

# Keep ANY class (and its constructor) annotated with @Command
-keep @picocli.CommandLine$Command class * {
<init>(...);
}

# Keep ANY field/method using a Picocli annotation (@Option, @Parameters, etc.)
-keepclassmembers class * {
@picocli.CommandLine$* *;
}


-keepclasseswithmembers class org.matrix.vector.daemon.env.LogcatMonitor {
private int refreshFd(boolean);
}
Expand Down