Consider abstract classes to have 70% abstractness.

They usually also contain some implementations and are ideally weighted for calculating the abstractness.

Author: JohT

cypher/Metrics/Calculate_and_set_Abstractness_for_Java.cypher

@@ -9,16 +9,20 @@ MATCH (artifact:Artifact)-[:CONTAINS]->(package)
      ,count{(package)-[:CONTAINS]->(:Annotation)}              AS numberAnnotations
      ,count{(package)-[:CONTAINS]->(:Interface)}               AS numberInterfaces
  WITH *
-     ,numberInterfaces + numberAnnotations + numberAbstractClasses AS numberAbstractTypes
+     ,numberInterfaces + numberAnnotations +  numberAbstractClasses        AS numberAbstractTypes
+     ,numberInterfaces + numberAnnotations + (numberAbstractClasses * 0.7) AS weightedAbstractTypes
  WITH *
-     ,toFloat(numberAbstractTypes) / (numberTypes + 1E-38) AS abstractness
-  SET package.abstractness          = abstractness
-     ,package.numberOfAbstractTypes = numberAbstractTypes
-     ,package.numberOfTypes         = numberTypes
+     ,toFloat(weightedAbstractTypes) / (numberTypes + 1E-38) AS abstractness
+  SET package.abstractness            = abstractness
+     ,package.numberOfAbstractTypes   = numberAbstractTypes
+     ,package.numberOfAbstractClasses = numberAbstractClasses
+     ,package.numberOfTypes           = numberTypes
 RETURN artifactName
       ,package.fqn  AS fullQualifiedPackageName
       ,package.name AS packageName
       ,abstractness
       ,numberAbstractTypes
       ,numberTypes
+      ,numberAbstractClasses
+      ,weightedAbstractTypes
 ORDER BY abstractness ASC, numberTypes DESC

cypher/Metrics/Calculate_and_set_Abstractness_for_Java_including_Subpackages.cypher

@@ -13,10 +13,14 @@ MATCH (artifact:Artifact)-[:CONTAINS]->(package)
      ,package
      ,sum(subpackage.numberOfTypes)            AS numberTypes
      ,sum(subpackage.numberOfAbstractTypes)    AS numberAbstractTypes
+     ,sum(subpackage.numberOfAbstractClasses)  AS numberAbstractClasses
      ,count(path) - 1                          AS numberOfIncludedSubPackages
      ,max(length(path))                        AS maxSubpackageDepth
  WITH *
-     ,toFloat(numberAbstractTypes) / (numberTypes + 1E-38) AS abstractness
+      // Calculate abstract classes out of abstract types and then add 70% of them back in (weighted)
+     ,numberAbstractTypes - (numberAbstractClasses * 0.3) AS weightedAbstractTypes
+ WITH *
+     ,toFloat(weightedAbstractTypes) / (numberTypes + 1E-38) AS abstractness
   SET package.abstractnessIncludingSubpackages          = abstractness
      ,package.numberOfAbstractTypesIncludingSubpackages = numberAbstractTypes
      ,package.numberOfTypesIncludingSubpackages         = numberTypes
@@ -26,6 +30,8 @@ RETURN artifactName
       ,abstractness
       ,numberAbstractTypes
       ,numberTypes
+      ,numberAbstractClasses
+      ,weightedAbstractTypes
       ,numberOfIncludedSubPackages
       ,maxSubpackageDepth
 ORDER BY abstractness ASC, maxSubpackageDepth DESC, numberTypes DESC

cypher/Metrics/Calculate_and_set_Abstractness_for_Typescript.cypher

@@ -10,16 +10,20 @@ OPTIONAL MATCH (projectdir:Directory)<-[:HAS_ROOT]-(project:TS:Project)-[:CONTAI
       ,count{(module)-[:EXPORTS]->(:TypeAlias)}             AS numberTypeAliases
       ,count{(module)-[:EXPORTS]->(:Interface)}             AS numberInterfaces
   WITH *
-      ,numberInterfaces + numberTypeAliases + numberAbstractClasses AS numberAbstractTypes
+      ,numberInterfaces + numberTypeAliases +  numberAbstractClasses        AS numberAbstractTypes
+      ,numberInterfaces + numberTypeAliases + (numberAbstractClasses * 0.7) AS weightedAbstractTypes
   WITH *
-      ,toFloat(numberAbstractTypes) / (numberTypes + 1E-38) AS abstractness
-   SET module.abstractness          = abstractness
-      ,module.numberOfAbstractTypes = numberAbstractTypes
-      ,module.numberOfTypes         = numberTypes
+      ,toFloat(weightedAbstractTypes) / (numberTypes + 1E-38) AS abstractness
+   SET module.abstractness            = abstractness
+      ,module.numberOfAbstractTypes   = numberAbstractTypes
+      ,module.numberOfAbstractClasses = numberAbstractClasses
+      ,module.numberOfTypes           = numberTypes
 RETURN projectName
       ,module.globalFqn  AS fullQualifiedModuleName
       ,module.name       AS moduleName
       ,abstractness
       ,numberAbstractTypes
       ,numberTypes
+      ,numberAbstractClasses
+      ,weightedAbstractTypes
 ORDER BY abstractness ASC, numberTypes DESC

cypher/Metrics/Clear_all_metrics.cypher

@@ -28,6 +28,7 @@ REMOVE package.incomingDependencies
       ,package.abstractness
       ,package.numberOfTypes
       ,package.numberOfAbstractTypes
+      ,package.numberOfAbstractClasses
       ,package.abstractnessIncludingSubpackages
       ,package.numberOfAbstractTypesIncludingSubpackages
       ,package.numberOfTypesIncludingSubpackages