Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy/internal-dependencies-related report entrypoints and top-level Jupyter notebooks, while keeping the internal-dependencies domain as the canonical home by updating its explore notebooks and adding a missing exploration query.
Changes:
- Removed legacy
scripts/reports/*CSV entrypoints for visibility + OO design metrics and deleted the corresponding top-leveljupyter/*.ipynbnotebooks. - Updated
domains/internal-dependencies/explore/*.ipynbnotebooks to reference the domain-localqueries/layout (and a few rootcypher/utilities via longer relative paths). - Added
Words_for_git_author_Wordcloud_with_frequency.cypherunderdomains/internal-dependencies/queries/exploration/and removeddomains/internal-dependencies/COPIED_FILES.md.
Reviewed changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/reports/VisibilityMetricsCsv.sh | Deleted legacy visibility-metrics CSV entrypoint. |
| scripts/reports/ObjectOrientedDesignMetricsCsv.sh | Deleted legacy OO design metrics CSV entrypoint. |
| jupyter/Wordcloud.ipynb | Deleted legacy top-level Wordcloud notebook. |
| jupyter/VisibilityMetricsTypescript.ipynb | Deleted legacy top-level TypeScript visibility notebook. |
| jupyter/VisibilityMetricsJava.ipynb | Deleted legacy top-level Java visibility notebook. |
| jupyter/ObjectOrientedDesignMetricsTypescript.ipynb | Deleted legacy top-level TypeScript OO metrics notebook. |
| jupyter/ObjectOrientedDesignMetricsJava.ipynb | Deleted legacy top-level Java OO metrics notebook. |
| jupyter/DependenciesGraphExplorationTypescript.ipynb | Deleted legacy top-level TypeScript dependency graph exploration notebook. |
| jupyter/DependenciesGraphExplorationJava.ipynb | Deleted legacy top-level Java dependency graph exploration notebook. |
| jupyter/PathFindingTypescript.ipynb | Deleted legacy top-level TypeScript path-finding notebook. |
| jupyter/PathFindingJava.ipynb | Deleted legacy top-level Java path-finding notebook. |
| jupyter/InternalDependenciesTypescript.ipynb | Deleted legacy top-level TypeScript internal-dependencies notebook. |
| jupyter/InternalDependenciesJava.ipynb | Deleted legacy top-level Java internal-dependencies notebook. |
| domains/internal-dependencies/queries/exploration/Words_for_git_author_Wordcloud_with_frequency.cypher | Added git-author wordcloud frequency query inside the internal-dependencies domain. |
| domains/internal-dependencies/explore/Wordcloud.ipynb | Updated query paths to use domains/internal-dependencies/queries/.... |
| domains/internal-dependencies/explore/VisibilityMetricsTypescript.ipynb | Updated query paths to domain queries/visibility/.... |
| domains/internal-dependencies/explore/VisibilityMetricsJava.ipynb | Updated query paths to domain queries/visibility/.... |
| domains/internal-dependencies/explore/PathFindingTypescript.ipynb | Updated query paths (domain path-finding queries + root Dependencies_Projection utilities). |
| domains/internal-dependencies/explore/PathFindingJava.ipynb | Updated query paths (domain path-finding queries + root Dependencies_Projection utilities). |
| domains/internal-dependencies/explore/ObjectOrientedDesignMetricsTypescript.ipynb | Updated query paths to domain queries/object-oriented-design-metrics/.... |
| domains/internal-dependencies/explore/ObjectOrientedDesignMetricsJava.ipynb | Updated query paths to domain queries/object-oriented-design-metrics/.... |
| domains/internal-dependencies/explore/InternalDependenciesTypescript.ipynb | Updated query paths to domain queries/internal-dependencies/... and queries/cyclic-dependencies/.... |
| domains/internal-dependencies/explore/InternalDependenciesJava.ipynb | Updated query paths to domain queries/internal-dependencies/..., queries/cyclic-dependencies/..., and queries/exploration/.... |
| domains/internal-dependencies/COPIED_FILES.md | Removed copied-files tracking doc (domain now treated as canonical). |
| cypher/Visibility/Relative_visibility_public_types_to_all_types_per_package.cypher | Deleted legacy root visibility query (domain-local replacement exists). |
| cypher/Visibility/Relative_visibility_exported_elements_to_all_elements_per_module_for_Typescript.cypher | Deleted legacy root visibility query (domain-local replacement exists). |
| cypher/Visibility/Global_relative_visibility_statistics_for_types.cypher | Deleted legacy root visibility query (domain-local replacement exists). |
| cypher/Visibility/Global_relative_visibility_statistics_for_elements_for_Typescript.cypher | Deleted legacy root visibility query (domain-local replacement exists). |
| cypher/Overview/Words_for_universal_Wordcloud.cypher | Deleted legacy root wordcloud query (domain-local replacement exists). |
| cypher/Metrics/Set_Outgoing_Typescript_Module_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Set_Outgoing_Java_Package_Dependencies_Including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Set_Outgoing_Java_Package_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Set_Incoming_Typescript_Module_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Set_Incoming_Java_Package_Dependencies_Including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Set_Incoming_Java_Package_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Outgoing_Typescript_Module_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Outgoing_Java_Package_Dependencies_Including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Outgoing_Java_Package_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Instability_for_Typescript.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Instability_for_Java_Including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Instability_for_Java.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Incoming_Typescript_Module_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Incoming_Java_Package_Dependencies_Including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Incoming_Java_Package_Dependencies.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Abstractness_for_Typescript.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Abstractness_for_Java_including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Get_Abstractness_for_Java.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Count_and_set_abstract_types.cypher | Deleted legacy root OO metrics prerequisite query (domain-local replacement exists). |
| cypher/Metrics/Calculate_distance_between_abstractness_and_instability_for_Typescript.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_distance_between_abstractness_and_instability_for_Java_including_subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_distance_between_abstractness_and_instability_for_Java.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_and_set_Instability_for_Typescript.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_and_set_Instability_for_Java_Including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_and_set_Instability_for_Java.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_and_set_Abstractness_for_Typescript.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_and_set_Abstractness_for_Java_including_Subpackages.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
| cypher/Metrics/Calculate_and_set_Abstractness_for_Java.cypher | Deleted legacy root OO metrics query (domain-local replacement exists). |
JohT
force-pushed
the
features/remove-deprecated-internal-dependencies-reports
branch
from
6b7f4db to
62e5f61
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 55 out of 56 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
COMMANDS.md:414
- This example is likely to fail as written:
executeJupyterNotebookReport.shassumes--jupyterNotebookis relative to./jupyter(seescripts/executeJupyterNotebookReport.sh,JUPYTER_NOTEBOOK_DIRECTORYdefault), but the linked notebook now lives underdomains/internal-dependencies/explore/. Update the example to either setJUPYTER_NOTEBOOK_DIRECTORY=./domains/internal-dependencies/explore(env var) or document a supported way to pass an explicit notebook path.
Here is an example on how to run the report [Wordcloud.ipynb](./domains/internal-dependencies/explore/Wordcloud.ipynb):
```shell
./scripts/executeJupyterNotebookReport.sh --jupyterNotebook Wordcloud.ipynb
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚙️ Optimization