Skip to content

docs: Update generated#1

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
actions/update-generated-files
Open

docs: Update generated#1
github-actions[bot] wants to merge 1 commit into
mainfrom
actions/update-generated-files

Conversation

@github-actions

Copy link
Copy Markdown

This PR was auto-generated by a GitHub Actions workflow.

It contains updates to doc files generated by cargo xtask update-generated.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 15, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot force-pushed the actions/update-generated-files branch from 672ac4a to 7689521 Compare August 4, 2025 04:40
Johan-Liebert1 added a commit that referenced this pull request Jul 1, 2026
The three-devices-partial-ESP scenario fails with "No device found for
/dev/loop1p1" because the dual-ESP test's cleanup leaves stale kernel
partition nodes and LVM device registrations.

The prior cleanup called `pvremove -f $loop` on the loop device itself
(e.g. /dev/loop0) instead of on the partitions where PVs actually live
(e.g. /dev/loop0p2), making it a no-op.  After `losetup -d`, the
kernel retained busy partition nodes.  When the next test reused the
loop device with a different partition layout, `partx -u` tried to
atomically reconcile old and new partitions — but could not remove the
busy stale partition bootc-dev#2, so it aborted entirely without adding the new
partition #1.

Fix both cleanup and setup:

Cleanup:
- pvremove on actual partition devices (p1/p2/p3), not the loop device
- wipefs -a on each partition to clear signatures holding references
- udevadm settle to let udev finish processing
- partx -d to remove kernel partition entries before losetup -d
- Remove /etc/lvm/devices/system.devices to clear stale device IDs

Setup (setup_disk_with_partitions, setup_disk_with_root):
- Replace `partx -u` with `partx -d` (ignore errors) then `partx -a`,
  so a stuck stale partition does not block adding new ones
- Replace `sleep 1sec` with `udevadm settle` for reliable synchronization

Co-Authored-By: Claude Opus 4.6
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1 added a commit that referenced this pull request Jul 1, 2026
The three-devices-partial-ESP scenario fails with "No device found for
/dev/loop1p1" because the dual-ESP test's cleanup leaves stale kernel
partition nodes and LVM device registrations.

The prior cleanup called `pvremove -f $loop` on the loop device itself
(e.g. /dev/loop0) instead of on the partitions where PVs actually live
(e.g. /dev/loop0p2), making it a no-op.  After `losetup -d`, the
kernel retained busy partition nodes.  When the next test reused the
loop device with a different partition layout, `partx -u` tried to
atomically reconcile old and new partitions — but could not remove the
busy stale partition bootc-dev#2, so it aborted entirely without adding the new
partition #1.

Fix both cleanup and setup:

Cleanup:
- pvremove on actual partition devices (p1/p2/p3), not the loop device
- wipefs -a on each partition to clear signatures holding references
- udevadm settle to let udev finish processing
- partx -d to remove kernel partition entries before losetup -d
- Remove /etc/lvm/devices/system.devices to clear stale device IDs

Setup (setup_disk_with_partitions, setup_disk_with_root):
- Replace `partx -u` with `partx -d` (ignore errors) then `partx -a`,
  so a stuck stale partition does not block adding new ones
- Replace `sleep 1sec` with `udevadm settle` for reliable synchronization

Co-Authored-By: Claude Opus 4.6
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants