ci: Add tests for grub-cc and systemd-boot

We don't have e2e upgrade tests for now, but we can atleast test if the
installations are working well

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

Author: Johan-Liebert1

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ on:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
+  cancel-in-progress: false
 
 env:
   CARGO_TERM_COLOR: always
@@ -74,7 +74,7 @@ jobs:
           build_args=()
 
           if [[ "${{ matrix.grubcc }}" == "1" ]]; then
-            dockerfile=Dockerfile.grubcc
+            dockerfile=Dockerfile.bls
             build_args=(--build-arg "grubcc=${{ matrix.grubcc }}")
           fi
 
@@ -143,3 +143,13 @@ jobs:
         run: |
           set -xeuo pipefail
           sudo podman run --rm -v $PWD:/run/src -w /run/src --privileged "$IMG_NAME" tests/tests/generate-update-metadata.sh
+
+      - name: Test GrubCC and SystemdBoot
+        run: |
+          if [[ "${{ matrix.grubcc }}" == "0" ]]; then
+            exit 0
+          fi
+
+          set -xeuo pipefail
+          sudo ./scripts/test-bootloader.sh "$IMG_NAME" "grub-cc"
+          sudo ./scripts/test-bootloader.sh "$IMG_NAME" "systemd-boot"

Dockerfile.grubcc Dockerfile.blsDockerfile.grubcc renamed to Dockerfile.bls

@@ -1,3 +1,4 @@
+# Dockerfile to test GrubCC and systemd-boot
 # Build from the current git into a fedora44 container image.
 
 ARG base=quay.io/fedora/fedora-bootc:44
@@ -42,15 +43,14 @@ mv ./*.rpm grub-cc.rpm
 EOF
 
 FROM $base
-ARG grubcc
 # Clean out the default to ensure we're using our updated content
 RUN rpm -e bootupd
 COPY --from=build /out/ /
 COPY --from=grub-cc-download /grub-cc.rpm /var/grub-cc.rpm
 # Install bootc from copr
 RUN --mount=type=tmpfs,target=/run --mount=type=tmpfs,target=/tmp <<EORUN
 set -xeuo pipefail
-dnf -y install dnf-plugins-core bootc
+dnf -y install dnf-plugins-core bootc systemd-boot tree
 dnf clean all
 rm -rf /var/log
 rm -rf /var/lib
@@ -59,6 +59,24 @@ rm -rf /run/rhsm
 rm -rf /tmp/*
 EORUN
 
+# Install systemd-boot
+RUN --mount=type=tmpfs,target=/run --mount=type=tmpfs,target=/tmp <<EOF
+set -eux
+# epoch for systemd-boot-unsigned is "(none)"
+evr=$(rpm -q --qf '%{EPOCH}:%{VERSION}-%{RELEASE}\n' systemd-boot-unsigned)
+rpm -ql systemd-boot-unsigned
+
+. /etc/os-release
+
+# Create the expected directory structure at /usr/lib/efi/grub-cc/<evr>/EFI/fedora/
+mkdir -p "/usr/lib/efi/systemd-boot/${evr}/EFI/$ID"
+
+# TODO: Handle arm
+cp /usr/lib/systemd/boot/efi/systemd-boot*.efi "/usr/lib/efi/systemd-boot/${evr}/EFI/$ID/grubx64.efi"
+
+EOF
+
+# Install grub-cc
 RUN --mount=type=tmpfs,target=/run --mount=type=tmpfs,target=/tmp <<EOF
 
 set -eux
@@ -68,11 +86,6 @@ cleanup() {
     rm -rvf /var/grub-cc*
 }
 
-if [[ ${grubcc} != 1 ]]; then
-    cleanup
-    exit 0
-fi
-
 # Extract and install grub-cc at the correct path
 mkdir /var/grub-cc
 rpm2archive /var/grub-cc.rpm | tar -xvz -C /var/grub-cc

scripts/test-bootloader.sh

@@ -0,0 +1,74 @@
+#!/bin/bash
+
+set -eux
+
+IMG_NAME=$1
+BOOTLOADER=$2
+
+cat <<-EOF > sfdisk-buf
+label: gpt
+label-id:  65be9332-59ba-11f1-9b26-6a8e2ab625e4
+size=1Gib, type=C12A7328-F81F-11D2-BA4B-00A0C93EC93B, name="EFI-SYSTEM"
+           type=4F68BCE3-E8CD-4DB1-96E7-FBCAF984B709, name="root"
+EOF
+
+truncate -s4G "${BOOTLOADER}-test.img"
+
+cat sfdisk-buf | sfdisk --wipe=always "${BOOTLOADER}-test.img"
+
+mkdir -p /var/mnt
+
+# Also update kernel partition tables
+loopdev=$(losetup --find --show --partscan "${BOOTLOADER}-test.img")
+sleep 1
+
+mkfs.vfat "${loopdev}p1"
+mkfs.ext4 "${loopdev}p2"
+
+mount "${loopdev}p2" /var/mnt
+
+ESP="/var/mnt/efi"
+
+mkdir -p $ESP
+mount "${loopdev}p1" $ESP
+
+
+# Test installing the bootloader
+podman run --rm --net=host --privileged --pid=host \
+  --privileged \
+  --security-opt label=type:unconfined_t \
+  --env RUST_LOG=trace \
+  -v /dev:/dev \
+  -v /var/mnt:/var/mnt \
+  "$IMG_NAME" \
+  bootupctl backend install --bootloader "$BOOTLOADER" /var/mnt -vvvv
+
+# Make sure bootupd-state.json is in the esp
+test -f "$ESP/bootupd-state.json"
+
+version=$(cat "$ESP/bootupd-state.json" | jq -r ".installed.EFI.meta.version")
+
+if [[ $version != *shim* ]]; then echo "shim not found in version"; exit 1; fi
+if [[ $version != *"$BOOTLOADER"* ]]; then echo "$BOOTLOADER not found in version"; exit 1; fi
+
+# Test if the correct binary has been installed
+actualShasum=$(podman run --rm "$IMG_NAME" find "/usr/lib/efi/$BOOTLOADER" -type f -exec sha512sum {} + | awk '{print $1}')
+actualShasum="sha512:$actualShasum"
+
+if [[ $(uname -m) == "x64" ]]; then
+    grubName="grubx64.efi"
+else
+    grubName="grubaa64.efi"
+fi
+
+# TODO: Remove hardcoded "fedora" once we have support in centos
+storedShasum=$(cat "$ESP/bootupd-state.json" | jq -r --arg grub "$grubName" '.installed.EFI.filetree.children["fedora/\($grub)"].sha512')
+
+test "$actualShasum" == "$storedShasum"
+
+efiBinShasum=$(find "$ESP" -type f -name "$grubName" -exec sha512sum {} + | awk '{print $1}')
+efiBinShasum="sha512:$efiBinShasum"
+
+test "$efiBinShasum" == "$actualShasum"
+
+umount -Rl /var/mnt