Wip/thread mention only#11
Merged
Merged
Conversation
Drop the active_threads thread-owner mechanism. Previously the first user to @mention the bot in a thread became its "owner" and could send plain follow-ups, while every other participant had to @mention every turn — an asymmetry that made multi-user threads awkward. Now channel and thread messages are only handled via the app_mention event, regardless of who started the thread. handle_message only handles DMs. This makes participation rules uniform: anyone joining a thread plays by the same gating as the original poster (@mention every turn). Memory remains keyed by thread_ts, so once a participant @mentions, they share the full thread history with everyone else in it. - Remove self.active_threads dict and the seeding in handle_mention - Simplify handle_message to only respond to channel_type == "im" - Remove unused _is_bot_mentioned helper - Tests: assert thread plain follow-ups are ignored even from the original mentioner; assert two users @mentioning the same thread share history
John-Lin
force-pushed
the
wip/thread-mention-only
branch
from
April 8, 2026 17:25
ade353c to
ee0f6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.