refactor: align shell and logging architecture with agentic-slackbot#19
Merged
Conversation
Port the full set of architecture changes from agentic-slackbot: - Replace SHELL_SKILLS_ENABLED boolean with orthogonal SHELL_ENABLED and SHELL_SKILLS_DIR env vars. SHELL_ENABLED is the sole on/off toggle; SHELL_SKILLS_DIR optionally mounts a skills directory. - _load_shell_skills() now takes an explicit Path argument instead of reading a module-level SKILLS_DIR constant. - Add _get_shell_environment() encapsulating the three-state logic with warnings for misconfiguration (orphaned SHELL_SKILLS_DIR, empty dir). - Add env_flag() helper in bot/config.py that treats "0", "false", "no", "off" as disabled, fixing the FOO=0 gotcha. - Extract _configure_logging() in app.py with AGENT_VERBOSE_LOG support (calls SDK's enable_verbose_stdout_logging() when set). - Rewrite TestLoadShellSkills -> TestShellToolConfiguration with cleaner helpers; add TestEnvFlag; update autouse fixture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the full set of architecture changes from agentic-slackbot: