Update ci.yml (to use non-deprecated upload-artifact action)

[meghfossa]

This updates to v4, as v3 is deprecated (and will actively throw error in CI)
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Starting January 30th, 2025, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact. Customers should update workflows to begin using v4 of the artifact actions as soon as possible. While v4 of the artifact actions improves upload and download speeds by up to 98% and includes several new features, there are key differences from previous versions that may require updates to your workflows. Please see the documentation in the project repositories for guidance on how to migrate your workflows.

[JohnBra]

Hey @meghfossa, thanks for opening this PR!

I just checked the breaking changes of v4 and it lists the deprecation of uploading artifacts with the same name.

Currently the zip will keep the name vite-web-extension-chrome with every upload. Can you confirm running the updated workflow will not throw an error after running it multiply times?

If it does throw an error, I suggest appending the version from the manifest.json or package.json to the filename.

[meghfossa]

I ran into following into CI -

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

I resolved it by bumping the version on my fork (so not a blocker or issue for me). Thanks for creating this template - this literally saved hours of js/ts/env setup. Feel free to close this PR