Skip to content

Upgrade SSH.NET version to 2024.0.0 and target newer frameworks#17

Open
dHamburgler wants to merge 6 commits into
JohnTheGr8:masterfrom
dHamburgler:develop
Open

Upgrade SSH.NET version to 2024.0.0 and target newer frameworks#17
dHamburgler wants to merge 6 commits into
JohnTheGr8:masterfrom
dHamburgler:develop

Conversation

@dHamburgler

Copy link
Copy Markdown
  • Use SSH.NET 2024.0.0
  • Minor code changes needed for the above version
  • Fix broken license tag + file

BREAKING CHANGE:

  • Dropped support for universal windows platform (SSH.NET no longer supports it). However netstandard2.0 can also be used

@ctrlaltf24

Copy link
Copy Markdown

@JohnTheGr8 Would it be possible to review this? SSH.NET that this project currently uses (from 2016) doesn't support rsa-sha2-*


<PropertyGroup>
<TargetFrameworks>netstandard1.3;net40;uap10.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462;</TargetFrameworks>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some modern target framework could be also added? .NET 8 ?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants