@W-19368426: [MSDK] Rewrite Android Screen Lock (a.k.a Passcode) for RTL UI (forcedotcom#2835)

Author: JohnsonEricAtSalesforce

libs/SalesforceSDK/AndroidManifest.xml

@@ -10,7 +10,7 @@
     <uses-permission android:name="android.permission.DOWNLOAD_WITHOUT_NOTIFICATION" />
     <uses-permission android:name="android.permission.USE_BIOMETRIC" />
 
-    <application>
+    <application android:supportsRtl="true">
 
         <!-- Metadata for supported app restrictions -->
         <meta-data android:name="android.content.APP_RESTRICTIONS"

libs/SalesforceSDK/build.gradle.kts

@@ -23,6 +23,7 @@ dependencies {
     api("androidx.browser:browser:1.8.0") // Update requires API 36 compileSdk
     api("androidx.work:work-runtime-ktx:2.10.3")
 
+    implementation("com.google.accompanist:accompanist-drawablepainter:0.37.3")
     implementation("com.google.android.material:material:1.13.0")  // remove this when all xml is gone
     implementation("androidx.appcompat:appcompat:1.7.1")
     implementation("androidx.biometric:biometric:1.2.0-alpha05")

libs/SalesforceSDK/res/layout/sf__screen_lock.xml

@@ -1,11 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <resources>
-    <!-- Dimensions used in sf__screen_lock.xml -->
-    <dimen name="sf__screenlock_error_margin_top">10dp</dimen>
-    <dimen name="sf__screenlock_error_margin_left">20dp</dimen>
-    <dimen name="sf__screenlock_error_margin_right">20dp</dimen>
-
     <!-- Biometric Enrollment Prompt -->
     <dimen name="sf__dialog_layout_padding">0dp</dimen>
-</resources>
+</resources>

libs/SalesforceSDK/res/values/sf__dimens.xml

@@ -206,16 +206,6 @@
         <item name="android:windowLightStatusBar">false</item>
     </style>
 
-    <style name="SalesforceSDK.ScreenLock.ErrorMessage">
-        <item name="android:layout_height">wrap_content</item>
-        <item name="android:gravity">center</item>
-        <item name="android:layout_gravity">center_horizontal</item>
-        <item name="android:layout_width">wrap_content</item>
-        <item name="android:layout_marginTop">@dimen/sf__screenlock_error_margin_top</item>
-        <item name="android:layout_marginLeft">@dimen/sf__screenlock_error_margin_left</item>
-        <item name="android:layout_marginRight">@dimen/sf__screenlock_error_margin_right</item>
-    </style>
-
     <style name="SalesforceSDK_Fullscreen" parent="@style/Theme.AppCompat.DayNight.NoActionBar">
         <item name="android:windowNoTitle">true</item>
         <item name="android:windowActionBar">false</item>

libs/SalesforceSDK/res/values/sf__styles.xml

@@ -82,7 +82,6 @@ import com.salesforce.androidsdk.R
 import com.salesforce.androidsdk.app.SalesforceSDKManager
 import com.salesforce.androidsdk.developer.support.DevSupportInfo
 import com.salesforce.androidsdk.ui.components.ICON_SIZE
-import com.salesforce.androidsdk.ui.components.PADDING_SIZE
 import com.salesforce.androidsdk.ui.components.TEXT_SIZE
 import com.salesforce.androidsdk.ui.theme.sfDarkColors
 import com.salesforce.androidsdk.ui.theme.sfLightColors

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/DevInfoActivity.kt

@@ -1,3 +1,29 @@
+/*
+ * Copyright (c) 2021-present, salesforce.com, inc.
+ * All rights reserved.
+ * Redistribution and use of this software in source and binary forms, with or
+ * without modification, are permitted provided that the following conditions
+ * are met:
+ * - Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ * - Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ * - Neither the name of salesforce.com, inc. nor the names of its contributors
+ * may be used to endorse or promote products derived from this software without
+ * specific prior written permission of salesforce.com, inc.
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
 package com.salesforce.androidsdk.ui
 
 import android.os.Bundle
@@ -55,8 +81,6 @@ import com.salesforce.androidsdk.R.string.sf__server_url_save
 import com.salesforce.androidsdk.app.SalesforceSDKManager
 import com.salesforce.androidsdk.config.BootConfig
 import com.salesforce.androidsdk.config.OAuthConfig
-import com.salesforce.androidsdk.ui.components.CORNER_RADIUS
-import com.salesforce.androidsdk.ui.components.PADDING_SIZE
 import com.salesforce.androidsdk.ui.components.TEXT_SIZE
 import com.salesforce.androidsdk.ui.theme.hintTextColor
 import com.salesforce.androidsdk.util.test.ExcludeFromJacocoGeneratedReport