@W-21933885: [MSDK Android] App Attestation Implementation (Automated Code Review #3. Over-exposed, unsynchronized, and semantically suspicious public API surface on SalesforceSDKManager + AppAttestationClient. c. updateAppAttestationClient likely uses the wrong host)

Author: JohnsonEricAtSalesforce

libs/SalesforceSDK/src/com/salesforce/androidsdk/app/SalesforceSDKManager.kt

@@ -251,23 +251,24 @@ open class SalesforceSDKManager protected constructor(
      * for the app in Google Play Console's Play Integrity API and provided to
      * the Salesforce App Attestation External Client App Plugin.
      *
-     * @param selectedLoginServerHost The selected login server configured with
-     * the Salesforce App Attestation ECA Plugin
+     * @param apiHostName The Salesforce App Attestation External Client App
+     * (ECA) Plugin Challenge API Host Name.  This usually matches the selected
+     * login server
      * @param googleCloudProjectId The Google Cloud Project ID or null to
      * disable Salesforce App Attestation
      */
     fun updateAppAttestationClient(
-        selectedLoginServerHost: String,
+        apiHostName: String,
         googleCloudProjectId: Long? = null
     ) {
         synchronized(appAttestationClientLock) {
             appAttestationClient = googleCloudProjectId?.let { appAttestationGoogleCloudProjectId ->
                 AppAttestationClient(
                     context = appContext,
-                    apiHostName = selectedLoginServerHost,
+                    apiHostName = apiHostName,
                     deviceId = deviceId,
                     googleCloudProjectId = appAttestationGoogleCloudProjectId,
-                    remoteAccessConsumerKey = getBootConfig(getInstance().appContext).remoteAccessConsumerKey,
+                    remoteAccessConsumerKey = getBootConfig(appContext).remoteAccessConsumerKey,
                     restClient = clientManager.peekUnauthenticatedRestClient()
                 )
             }

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/app/SalesforceSDKManagerTests.kt

@@ -301,7 +301,7 @@ class SalesforceSDKManagerTests {
         )
 
         salesforceSdkManager.updateAppAttestationClient(
-            selectedLoginServerHost = "login.example.com",
+            apiHostName = "login.example.com",
             googleCloudProjectId = 123456
         )