Remove vendored try_call, use process.call instead#30
Open
GG-O-BP wants to merge 2 commits into
Open
Conversation
| process.send(browser, RemoveListener(event_subject)) | ||
| call_response | ||
| |> result.map_error(map_call_error) | ||
| let assert Ok(event_data) = result |
Owner
There was a problem hiding this comment.
I don't see a good reason to panic here, let's just return the result from process.receive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the vendored
try_callwithprocess.calldirectly in the chrome actor'squit,call, andlisten_oncefunctions, as discussed in #28.ChromeAgentDownhad no producer left after the change so I dropped it. Also updated theChromeAgentTimeoutcomment since it's only used in polling now, not for actual actor timeouts those just panic. Fixed a staletry_awaitreference indo_pollwhile I was at it.The code gets simpler since we no longer need
CallError,map_call_error, or the vendoredtry_call/try_call_with_subjectin the hot path.Closes #28