[McWebserver-worker/ERROR]: Uncaught exception in thread "McWebserver-worker" logs on 1.21 fabric 0.3.5

[ZewZack]

Hello. Thanks for your hard work on this mod.

I sometimes see this " "String.lenght()" because str is null" issue while checking 8080 port.
But I don't see when I normally checking the webserver on browser.

Also as you can see from the picture, some maniacs trying some exploits like "boaform/admin/formlogin?" xd.

Since I have a cgnat ip, I make a reverse ssh tunneling to my amazon ec2 server. so players can connect with ec2 ip address to my mc and website.

I'm checking the server 24/7 for security reasons and I don't think these errors will going to be a big headache to me, am i right?

[JonasunderscoreJones]

Thanks!!
All of these errors shouldn't appear like that in the console. I'll have to look into it.

I think the reason for why you're not getting a log when you check it by yourself is because verbose logging is disabled. It can be enabled in the config file and will show every request to the webserver of the mod.

They shouldn't, no. the exploit spam with the path "boa form/admin/form login?" doesn't lead anywhere and hence returns a 404 error to the server it's pinging from so you won't have to worry about that. I am however unsure as to why it's returning an error. I think it's due to the questionmark not being parsed to a path and me not implementing a failsafe for it.

As for the other String.length() error, I seem to have forgotten about a possible error that can occur.

Both should be as simple as implementing fallbacks. I should have some time later tonight, I'll fix it asap. I can't guarantee the safety of your server, as always, but in my opinion there is nothing to worry about.

Cheers and thanks for submitting the issue! I'm glad that this is something most people won't even notice hahaha. I was getting worried when I saw the issue on GitHub :)

[ZewZack]

hahaha sorry for that xD. also thanks for your quick response too. have a wonderful day / night <3

[JonasunderscoreJones]

Ok, I finally found the time to look into the issue again, sorry about taking so long. I did implement a fix for the first 2 errors of your screenshot. I have a test build that you could try: https://fileshare.jonasjones.dev/download/XTuqwM0W0FqSbQcaKgtR6 Feel free to check if the errors still appear. As for the 3rd one, I don't know what is going on with it. Could you enable verbose logging and send me the log for this request, once it reappears? I tested a request with "boaform/admin/formlogin?ec8&psd=ec8" just like the screenshots shows, but I don't get any errors...