Changed from list to dict for adding subfields to a field at creation

Author: Reedyn

almamarc/__init__.py

@@ -67,17 +67,18 @@ def add_field(self, tag, field_type='datafield', ind1='', ind2='', subfields=Non
         new_field = ElementTree.Element(field_type, tag=tag, ind1=ind1, ind2=ind2)
 
         if subfields is None:
-            subfields = []
-        for subfield in subfields:
-            new_subfield = ElementTree.Element('subfield', code=subfield['code'])
-            new_subfield.text = subfield['value']
+            subfields = {}
+        for code, value in subfields.items():
+            new_subfield = ElementTree.Element('subfield', code=code)
+            new_subfield.text = value
             new_field.append(new_subfield)
 
         record_root.append(new_field)
         fields = self.get_fields(tag=tag, field_type=field_type)
         return fields
 
     def to_string(self):
+        # Write to fake file so that we can write our own XML declaration string.
         fake_file = bytes()
         self.xml.write(fake_file, encoding='utf-8', xml_declaration=False)
         return '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>' + fake_file.getvalue().decode('utf-8')

setup.py

@@ -1,7 +1,7 @@
 from setuptools import setup
 
 setup(name='almaapi',
-      version='0.1',
+      version='1.0',
       description='Python module for making requests to the Alma API',
       url='https://github.com/JonkopingUniversityLibrary/almaapi',
       author='Gustav Lindqvist',