Skip to content

Commit de82eb4

Browse files
committed
Remove known issue docs after fixing test crash
1 parent 97dbf88 commit de82eb4

3 files changed

Lines changed: 2 additions & 11 deletions

File tree

AGENTS.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ Use git worktrees to work on multiple cards in parallel without branch conflicts
3838
- Add tests for remaining uncovered edge cases
3939
- Add tests for complex error handling paths
4040
- Add tests for platform-specific code paths
41-
- **Known Issue**: Test suite crashes with coverage enabled due to parallel worker threads not being properly stopped (see `test_parallel_workers.py`). Run coverage tests excluding parallel tests: `uv run pytest --cov=cdisplayagain --cov-report=term-missing -k "not parallel"`
4241

4342
## Performance Guidelines
4443
- Image resizing (LANCZOS resampling) is the primary bottleneck (~65% of CPU time)

docs/archive/TESTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ uv run --active pytest tests/test_performance.py -v --no-cov
1818
# Run specific test
1919
uv run --active pytest tests/test_performance.py::test_perf_launch_sample_comics -v -s --no-cov
2020

21-
# Run coverage tests (excluding parallel worker tests which crash with coverage)
22-
uv run pytest tests/ -k "not parallel" --cov=cdisplayagain --cov-report=term-missing
21+
# Run coverage tests
22+
uv run pytest tests/ --cov=cdisplayagain --cov-report=term-missing
2323
```
2424

2525
### Manual Testing

tasks.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@ WIP limit: 3 cards total in In Progress.
4545
- Add tests for complex error handling paths
4646
- Add tests for platform-specific code paths
4747

48-
**Test Coverage Reports:**
49-
- Run with coverage (excluding parallel tests): `uv run pytest --cov=cdisplayagain --cov-report=term -q -k "not parallel"`
50-
- Check missing lines: `uv run pytest --cov=cdisplayagain --cov-report=term-missing -k "not parallel"`
51-
- Coverage threshold configured in `pyproject.toml`
52-
53-
**Known Issues:**
54-
- Test suite crashes with full coverage run due to parallel worker threads in `test_parallel_workers.py` and `test_benchmark_parallel.py` not being properly stopped. These tests create infinite-loop threads that survive test teardown and cause coverage collection to crash. Fix requires adding proper thread cleanup to `ImageWorker`.
55-
5648
### Future Features & Parity Items
5749
- The info screen can be dismissed by double-click or any key press (✅ implemented).
5850
- You can drag the page around with the mouse (panning).

0 commit comments

Comments
 (0)