[12.x] Fix File::types() silently discarding chain configuration#10
Closed
JoshSalway wants to merge 2 commits into12.xfrom
Closed
[12.x] Fix File::types() silently discarding chain configuration#10JoshSalway wants to merge 2 commits into12.xfrom
JoshSalway wants to merge 2 commits into12.xfrom
Conversation
The types() method was declared as static, which meant calling it on an existing File instance (e.g. File::image()->max(1)->types(['jpg'])) would silently create a new instance, discarding all prior configuration like max(), min(), etc. This changes types() to work both as a static factory method and as a chainable instance method by leveraging __call and __callStatic magic methods. The underlying logic is moved to setTypes(). Fixes laravel#59242 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that calling types() on an existing File instance preserves prior configuration (e.g. max()) instead of creating a new instance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Moved upstream → laravel#59324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File::types()silently discarding prior chain configuration when called as an instance method (e.g.,File::image()->max(1)->types(['jpg'])would lose themax(1)constraint)types()method wasstatic, so calling it on an instance created a newFileobject, dropping all previously configured rulesFile::types('png')) and as a chainable instance method (File::image()->max(1)->types(['jpg']))Test plan
max()constraint is preserved whentypes()is called after itFixes laravel#59242
🤖 Generated with Claude Code