Merge pull request #4924 from mnaamani/colossus-longer-default-sync-interval

colossus: sync - longer default interval

Author: mnaamani

storage-node/CHANGELOG.md

@@ -1,5 +1,6 @@
 ### 3.9.0
 
+- Increase default interval between sync runs. Start sync run immediately do not wait initial interval on startup before starting sync. Adds additional optional argument to specify retry interval on failure. [#4924](https://github.com/Joystream/joystream/pull/4924)
 - Add background pruning worker to delete data objects which the node is no longer obligated to store. New optional argument `--cleanup` and `--cleanupInterval`
 - Added new `AcceptPendingObjectsService` that is responsible for periodically sending batch `accept_pending_data_objects` for all the pending data objects. The `POST /files` endpoint now no longer calls the `accept_pending_data_objects` extrinsic for individual uploads, instead, it registers all the pending objects with `AcceptPendingObjectsService`
 - Updated `/state/data` endpoint response headers to return data objects status too i.e. (`pending` or `accepted`)
@@ -20,7 +21,7 @@
 
 ### 3.7.1
 
-- Disable open-api express response validation if NODE_ENV == 'production'. This should improve response times when serving assets.
+- Disable open-api express response validation if NODE_ENV == 'production'. This should improve response times when serving assets. [#4810](https://github.com/Joystream/joystream/pull/4810)
 - Include `nodeEnv` in `/api/v1/status` response, to help detect mis-configured nodes.
 
 ### 3.7.0

storage-node/src/commands/server.ts

@@ -65,7 +65,11 @@ export default class Server extends ApiCommandBase {
     syncInterval: flags.integer({
       char: 'i',
       description: 'Interval between synchronizations (in minutes)',
-      default: 1,
+      default: 20,
+    }),
+    syncRetryInterval: flags.integer({
+      description: 'Interval before retrying failed synchronization run (in minutes)',
+      default: 3,
     }),
     cleanup: flags.boolean({
       char: 'c',
@@ -255,7 +259,8 @@ Supported values: warn, error, debug, info. Default:debug`,
             TempDirName,
             flags.syncWorkersNumber,
             flags.syncWorkersTimeout,
-            flags.syncInterval
+            flags.syncInterval,
+            flags.syncRetryInterval
           ),
         0
       )
@@ -338,6 +343,7 @@ Supported values: warn, error, debug, info. Default:debug`,
  * @param syncWorkersNumber - defines a number of the async processes for sync
  * @param syncWorkersTimeout - downloading asset timeout
  * @param syncIntervalMinutes - defines an interval between sync runs
+ * @param syncRetryIntervalMinutes - defines an interval before retrying sync run after critical error
  *
  * @returns void promise.
  */
@@ -350,12 +356,12 @@ async function runSyncWithInterval(
   tempDirectory: string,
   syncWorkersNumber: number,
   syncWorkersTimeout: number,
-  syncIntervalMinutes: number
+  syncIntervalMinutes: number,
+  syncRetryIntervalMinutes: number
 ) {
-  const sleepInteval = syncIntervalMinutes * 60 * 1000
+  const sleepInterval = syncIntervalMinutes * 60 * 1000
+  const retrySleepInterval = syncRetryIntervalMinutes * 60 * 1000
   while (true) {
-    logger.info(`Sync paused for ${syncIntervalMinutes} minute(s).`)
-    await sleep(sleepInteval)
     try {
       logger.info(`Resume syncing....`)
       await performSync(
@@ -368,8 +374,12 @@ async function runSyncWithInterval(
         uploadsDirectory,
         tempDirectory
       )
+      logger.info(`Sync run complete. Next run in ${syncIntervalMinutes} minute(s).`)
+      await sleep(sleepInterval)
     } catch (err) {
       logger.error(`Critical sync error: ${err}`)
+      logger.info(`Will retry in ${syncRetryIntervalMinutes} minute(s)`)
+      await sleep(retrySleepInterval)
     }
   }
 }