Skip to content

Commit 195bd20

Browse files
committed
removed the unnecessary markup() wrapper
1 parent 3a2a042 commit 195bd20

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

jsweb/forms.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,14 @@ def __call__(self, **kwargs):
155155
kwargs.setdefault('id', self.name)
156156
kwargs.setdefault('name', self.name)
157157

158-
html = [f'<select {Markup(" ".join(f"{k}=\"{v}\"" for k, v in kwargs.items()))}>']
158+
attrs_str = " ".join(f'{k}="{v}"' for k, v in kwargs.items())
159+
html = [f'<select {attrs_str}>']
159160
for value, label, selected in self:
160161
option_attrs = {'value': value}
161162
if selected:
162163
option_attrs['selected'] = 'selected'
163-
html.append(f'<option {" ".join(f"{k}=\"{v}\"" for k, v in option_attrs.items())}>{label}</option>')
164+
option_attrs_str = " ".join(f'{k}="{v}"' for k, v in option_attrs.items())
165+
html.append(f'<option {option_attrs_str}>{label}</option>')
164166
html.append('</select>')
165167
return Markup(''.join(html))
166168

0 commit comments

Comments
 (0)