Skip to content

Use MultiDocumenter.jl#43

Merged
abhro merged 30 commits into
sourcefrom
multidocumenter
Apr 12, 2025
Merged

Use MultiDocumenter.jl#43
abhro merged 30 commits into
sourcefrom
multidocumenter

Conversation

@icweaver
Copy link
Copy Markdown
Member

@icweaver icweaver commented Apr 4, 2025

This PR tries to get MultiDocumenter in the mix next. This is inspired from this old convo

Depends on #40

It seems to be building locally alright for me (pics below), but I am lost when it comes to CI stuff. Any help is appreciated!

Demo

Preview link

https://juliaastro.org/previews/PR43/

Doesn't seem to be reflecting changes yet, I am positive that I must be holding it wrong It's working now, thanks @abhro!

Unified search

image

Topbar links to external package docs

image

Future PR(s)?

  • Sync list of docs in docs/make.jl with pages.jl. Currently doing this manually (WIP here: Simplified MultiDocumenter.jl #44)
  • More informative unified search. Would be cool to prepend the parent package name to search result hits to give them more context

@abhro abhro self-requested a review April 5, 2025 16:46
Comment thread docs/make.jl Outdated
push_preview = true,
branch = "master",
devbranch = "source"
devbranch = "multidocumenter",
Copy link
Copy Markdown
Member

@abhro abhro Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed back to devbranch = "source" before merging?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You read my mind. Wasn't sure how that would play with PR doc previews, but totally happy to switch it back if it looks good to you!

Comment thread docs/make.jl Outdated
@abhro abhro requested a review from mileslucas April 5, 2025 21:47
@abhro abhro marked this pull request as ready for review April 5, 2025 21:48
@abhro abhro requested a review from giordano April 5, 2025 22:41
@sefffal
Copy link
Copy Markdown
Member

sefffal commented Apr 7, 2025

Wow @icweaver , this is amazing! Thank you for setting this up!

@icweaver icweaver changed the title Multidocumenter experiment Use MultiDocumenter.jl Apr 9, 2025
Comment thread docs/make.jl
Comment on lines +48 to +241
docs = [
# We also add JuliaAstro's own generated pages
MultiDocumenter.MultiDocRef(
upstream = joinpath(@__DIR__, "build"),
path = "docs",
name = "JuliaAstro",
fix_canonical_url = false,
),
MultiDocumenter.DropdownNav(
"Time, Coordinates, & Units",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "AstroAngles"),
path = "AstroAngles",
name = "AstroAngles",
giturl = "https://github.com/JuliaAstro/AstroAngles.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "AstroTime"),
path = "AstroTime",
name = "AstroTime",
giturl = "https://github.com/JuliaAstro/AstroTime.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "ERFA"),
path = "ERFA",
name = "ERFA",
giturl = "https://github.com/JuliaAstro/ERFA.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "SkyCoords"),
path = "SkyCoords",
name = "SkyCoords",
giturl = "https://github.com/JuliaAstro/SkyCoords.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "UnitfulAstro"),
path = "UnitfulAstro",
name = "UnitfulAstro",
giturl = "https://github.com/JuliaAstro/UnitfulAstro.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "WCS"),
path = "WCS",
name = "WCS",
giturl = "https://github.com/JuliaAstro/WCS.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Images",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "AstroImages"),
path = "AstroImages",
name = "AstroImages",
giturl = "https://github.com/JuliaAstro/AstroImages.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "SAOImagesDS9"),
path = "SAOImagesDS9",
name = "SAOImagesDS9",
giturl = "https://github.com/JuliaAstro/SAOImageDS9.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "Photometry"),
path = "Photometry",
name = "Photometry",
giturl = "https://github.com/juliaastro/Photometry.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "PSFModels"),
path = "PSFModels",
name = "PSFModels",
giturl = "https://github.com/juliaastro/PSFModels.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "LACosmic"),
path = "LACosmic",
name = "LACosmic",
giturl = "https://github.com/juliaastro/LACosmic.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Data I/O",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "AstroImages"),
path = "AstroImages",
name = "AstroImages",
giturl = "https://github.com/JuliaAstro/AstroImages.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "FITSIO"),
path = "FITSIO",
name = "FITSIO",
giturl = "https://github.com/JuliaAstro/FITSIO.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "CFITSIO"),
path = "CFITSIO",
name = "CFITSIO",
giturl = "https://github.com/JuliaAstro/CFITSIO.jl.git",
),
MultiDocumenter.Link(
"mweastwood/CasaCore",
"http://mweastwood.info/CasaCore.jl/stable/",
),
MultiDocumenter.Link(
"emmt/OIFITS",
"https://github.com/emmt/OIFITS.jl",
),
MultiDocumenter.Link(
"aplavin/VLBIData",
"https://github.com/JuliaAPlavin/VLBIData.jl",
),
MultiDocumenter.Link(
"aplavin/Difmap",
"https://github.com/JuliaAPlavin/Difmap.jl",
),
]
),
MultiDocumenter.DropdownNav(
"Cosmology",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "Cosmology"),
path = "Cosmology",
name = "Cosmology",
giturl = "https://github.com/JuliaAstro/Cosmology.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Orbits & Ephemerides",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "Transits"),
path = "Transits",
name = "Transits",
giturl = "https://github.com/JuliaAstro/Transits.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "sefffal/PlanetOrbits"),
path = "sefffal/PlanetOrbits",
name = "sefffal/PlanetOrbits",
giturl = "https://github.com/sefffal/PlanetOrbits.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "EarthOrientation"),
path = "EarthOrientation",
name = "EarthOrientation",
giturl = "https://github.com/JuliaAstro/EarthOrientation.jl.git",
),
MultiDocumenter.Link(
"JPLEphemeris",
"https://github.com/JuliaAstro/JPLEphemeris.jl",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "AstroLib"),
path = "AstroLib",
name = "AstroLib",
giturl = "https://github.com/JuliaAstro/AstroLib.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Numerical Utilities",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "BoxLeastSquares"),
path = "BoxLeastSquares",
name = "BoxLeastSquares",
giturl = "https://github.com/JuliaAstro/BoxLeastSquares.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "LombScargle"),
path = "LombScargle",
name = "LombScargle",
giturl = "https://github.com/JuliaAstro/LombScargle.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Statistics",
[
MultiDocumenter.Link(
"sefffal/PairPlots",
"https://sefffal.github.io/PairPlots.jl/dev",
),
]
),
]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit is all manual and gross for now just to stand things up, and can be replaced by something like #44 if we end up wanting to go the "single source of truth" route discussed there

@icweaver
Copy link
Copy Markdown
Member Author

icweaver commented Apr 10, 2025

#44 has been working better than expected, so I'm actually inclined to just have it subsume #40 and this PR at this point. What do y'all think?

@abhro
Copy link
Copy Markdown
Member

abhro commented Apr 11, 2025

#44 has been working better than expected, so I'm actually inclined to just have it subsume #40 and this PR at this point. What do y'all think?

Yes, I think that would be the final option to go with, but I'm not sure about #44 subsuming this PR. The ecosystem layout doesn't exactly much the current categorization, and at least from my perspective, the current one is easier to use. But that's a small change to make, so it's not too big of an issue.

The other part is, I'm not sure why the ecosystem page was hidden in the first place, so it's probably worth it to wait and hear from someone who oversaw the previous layout transition 👍
And also, thank you for your amazing work on this!

@icweaver
Copy link
Copy Markdown
Member Author

Thanks, sounds good! Maybe @sefffal has some thoughts?

@abhro abhro merged commit 158e4fe into source Apr 12, 2025
@abhro abhro deleted the multidocumenter branch April 12, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants