Skip to content

Commit 6183408

Browse files
baggepinnenclaude
andcommitted
Require MultibodyComponents 0.2.1 and drop the temporary CI step
MultibodyComponents v0.2.1 containing the BodyShape center-of-mass fix (JuliaComputing/MultibodyComponents.jl#150) is now registered, so the temporary CI step installing it from the main branch is removed and the compat bound is raised to require the fixed release. The SSH-agent step now only runs when the secret is configured, since all dependencies are registered and only JULIAHUB_TOKEN_ENCODED is strictly needed. Full test suite passes locally against the registered v0.2.1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent ec952e6 commit 6183408

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

.github/workflows/CI.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,12 @@ jobs:
4343
# private repository and cannot be resolved from this public repository,
4444
# so the equivalent registry setup is spelled out here with the public
4545
# actions it wraps.
46+
# All dependencies are registered, so an SSH identity is only set up when
47+
# the secret is available (needed only if git-tracked dependencies are
48+
# ever added).
4649
- name: "Set up SSH agent for private Git dependencies"
4750
uses: "webfactory/ssh-agent@e83874834305fe9a4a2997156cb26c5de65a8555" # v0.10.0
51+
if: ${{ secrets.JULIASIM_REGISTRY_SSH_KEY != '' }}
4852
with:
4953
ssh-private-key: "${{ secrets.JULIASIM_REGISTRY_SSH_KEY }}"
5054

@@ -72,16 +76,6 @@ jobs:
7276
private_registry_name: "DyadRegistry"
7377
private_registry_uuid: "07e6f81e-a02a-4ea6-9289-c3820c24b8ed"
7478

75-
# TEMPORARY: the 3D models require the BodyShape center-of-mass fix
76-
# (JuliaComputing/MultibodyComponents.jl#150), which is not yet in any
77-
# registered MultibodyComponents release. Remove this step and bump the
78-
# MultibodyComponents compat bound once a release containing the fix is
79-
# registered.
80-
- name: Use MultibodyComponents from main (pending release with BodyShape fix)
81-
run: julia --project=. -e 'using Pkg; Pkg.add(url="git@github.com:JuliaComputing/MultibodyComponents.jl.git", rev="main")'
82-
env:
83-
JULIA_PKG_USE_CLI_GIT: "true"
84-
8579
- uses: julia-actions/julia-buildpkg@e3eb439fad4f9aba7da2667e7510e4a46ebc46e1 # v1
8680

8781
- name: Run tests with virtual display

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ DyadInterface = "6, 7"
2727
Markdown = "1"
2828
ModelingToolkit = "11"
2929
Moshi = "0.3"
30-
MultibodyComponents = "0.2"
30+
MultibodyComponents = "0.2.1"
3131
OrdinaryDiffEqDefault = "1.12.0, 2"
3232
PrecompileTools = "1"
3333
RotationalComponents = "2"

0 commit comments

Comments
 (0)