Commit ebe36f9
Extend job launches with Git revision, access modes (#154)
* feat: support expose in package jobs
* wip support for public, dns
* try adding batchimages
* fix
* support for revision
* Exposing port on batchjob (#158)
* fix: adjust tests to new .jobaccess field
* docs: document the new remote-access and revision types
Adds docstrings for JobAccessMode, JobRemoteAccess, PackageAppRevision,
LatestRelease, Branch, and GitRevision, and includes them in the reference
manual (required by Documenter's checkdocs=:all). Also redacts the password
in JobAccessMode.Password's printed representation.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor: share the JobRemoteAccess submission argument mapping
Extracts _jobaccess_auth_args and _jobaccess_submit_args, used by the batch,
package, and application job submission paths. This also fixes package jobs
crashing with a MethodError when submitted with the (unsupported) Password or
LoggedInUsers access modes: all paths now throw an InvalidRequestError that
does not leak the password into the error message.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix: extract interactive product resolution for port-exposing jobs
The batch path now resolves the interactive product via a helper, fixing a
latent FieldError on its error path (BatchImage has .product, not
.product_name). Package (userapp) jobs intentionally keep the hardcoded
'package-interactive' product, now documented with a comment.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat: implement Password and LoggedInUsers access modes
Maps all four JobAccessMode variants to the backend's legacy appArgs
encoding (normalized by translate_auth_args! server-side). Also makes the
default LatestRelease revision omit branch_name from the submission instead
of sending an empty string, matching the wire format of older clients.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: cover JobRemoteAccess, access modes, and PackageJob revisions
Adds unit tests for the access-mode appArgs encodings (incl. password
redaction in printing), _jobaccess_submit_args, interactive product
resolution, and the revision argument mapping; exercises
expose=JobRemoteAccess end-to-end against the mocked backend. Also adds the
new public types to the public API allowlist.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: document JobRemoteAccess in submit_job, PackageJob, and the guide
Documents the expose kwarg's JobRemoteAccess option (incl. the port-only
default of JustMe + random DNS prefix), the new PackageJob image/revision
kwargs, adds a guide example and changelog entries, and fixes a module-
docstring cross-reference that broke the Documenter build.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: format files
---------
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
Co-authored-by: Criston Hyett <cmhyett@gmail.com>
Co-authored-by: Sebastian Pfitzner <sebastian@juliahub.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>1 parent a0c19ac commit ebe36f9
6 files changed
Lines changed: 395 additions & 75 deletions
File tree
- docs/src
- guides
- reference
- src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
| |||
240 | 245 | | |
241 | 246 | | |
242 | 247 | | |
| 248 | + | |
| 249 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
268 | 283 | | |
269 | 284 | | |
270 | 285 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| 272 | + | |
| 273 | + | |
272 | 274 | | |
273 | 275 | | |
274 | 276 | | |
| |||
287 | 289 | | |
288 | 290 | | |
289 | 291 | | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
290 | 296 | | |
291 | 297 | | |
292 | 298 | | |
| |||
0 commit comments