Extend job launches with Git revision, access modes#154
Merged
Conversation
Member
Adds docstrings for JobAccessMode, JobRemoteAccess, PackageAppRevision, LatestRelease, Branch, and GitRevision, and includes them in the reference manual (required by Documenter's checkdocs=:all). Also redacts the password in JobAccessMode.Password's printed representation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Extracts _jobaccess_auth_args and _jobaccess_submit_args, used by the batch, package, and application job submission paths. This also fixes package jobs crashing with a MethodError when submitted with the (unsupported) Password or LoggedInUsers access modes: all paths now throw an InvalidRequestError that does not leak the password into the error message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The batch path now resolves the interactive product via a helper, fixing a latent FieldError on its error path (BatchImage has .product, not .product_name). Package (userapp) jobs intentionally keep the hardcoded 'package-interactive' product, now documented with a comment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Maps all four JobAccessMode variants to the backend's legacy appArgs encoding (normalized by translate_auth_args! server-side). Also makes the default LatestRelease revision omit branch_name from the submission instead of sending an empty string, matching the wire format of older clients. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds unit tests for the access-mode appArgs encodings (incl. password redaction in printing), _jobaccess_submit_args, interactive product resolution, and the revision argument mapping; exercises expose=JobRemoteAccess end-to-end against the mocked backend. Also adds the new public types to the public API allowlist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Documents the expose kwarg's JobRemoteAccess option (incl. the port-only default of JustMe + random DNS prefix), the new PackageJob image/revision kwargs, adds a guide example and changelog entries, and fixes a module- docstring cross-reference that broke the Documenter build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pfitzseb
marked this pull request as ready for review
July 13, 2026 13:39
pfitzseb
self-requested a review
July 13, 2026 13:40
pfitzseb
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.