Return a callable object from install()#53
Merged
Conversation
Member
|
The return value is technically meaningful, since it's the only way to unregister the auth handler from Pkg at a later time. That said, I wouldn't mind removing that functionality from |
install()install()
Member
Author
|
@pfitzseb I updated it to return a callable object instead. Should be good to go if we're happy with it. |
pfitzseb
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value can be confusing to users, since it looks a bit like an error message:
So let's wrap it in an object, so we can have a more informative
showrepresentation:Also add docs to explain what this is for.
cc @ranjanan