Skip to content

Allow passing in SSA uses for debugging#3

Merged
Keno merged 3 commits intoJuliaComputing:mainfrom
serenity4:add-ssa-uses
Jun 2, 2025
Merged

Allow passing in SSA uses for debugging#3
Keno merged 3 commits intoJuliaComputing:mainfrom
serenity4:add-ssa-uses

Conversation

@serenity4
Copy link
Copy Markdown
Contributor

This introduces a mechanism to associate SSA uses with equations or variables, to be used in a % column for each.

Comment thread src/debug.jl Outdated
Comment thread src/debug.jl
if i <= 1
return (Label.(("# eq", "∂ₜ", " ", " ", "", "# v", "∂ₜ", " ", " ")))[j]
elseif j == 5
return (Label.(("# eq", "∂ₜ", " ", " ", "%", "", "# v", "∂ₜ", " ", " ", "%")))[j]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should depend on whether the column exists.

Copy link
Copy Markdown
Contributor Author

@serenity4 serenity4 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We increment j right before if it doesn't, so when it comes to 5 it gets incremented to 6 thus skipping the "%" column.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Carry on.

@serenity4
Copy link
Copy Markdown
Contributor Author

I tested locally with and without SSAUses, and it works correctly with JuliaComputing/DAECompiler.jl#48. It should be good to merge, I guess no need to increment the version yet as we use the #main ref in our manifest.

@Keno Keno merged commit 8220adc into JuliaComputing:main Jun 2, 2025
1 check passed
@serenity4 serenity4 deleted the add-ssa-uses branch June 2, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants