You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The additional_observed field of TearingState contains observed equations identified through processes other than tearing. Typically, this was only populated by the trivial_tearing! pass in StateSelection. However, MTK handles discrete systems by shifting them forward by a step (x(k) becomes x(k+1)). It omitted doing so on ::TearingState.original_eqs, which is what trivial_tearing! relies on. As a result, trivial_tearing! never did anything on discrete systems (since the equations didn't match what it expected) and additional_observed was never tested for such systems. SciML/ModelingToolkit.jl#4402 utilizes additional_observed for all systems, which exposed this bug. This PR now appropriately shifts original_eqs, which means trivial_tearing! does its job (also part of the test) and additional_observed is backshifted in reassembly to generate appropriate observed equations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.