feat: add new trivial_tearing! API#55
Merged
Merged
Conversation
AayushSabharwal
force-pushed
the
as/fix-trivial-tearing
branch
from
fec86e0 to
d2a5a7d
Compare
AayushSabharwal
force-pushed
the
as/fix-trivial-tearing
branch
from
d2a5a7d to
0a7085e
Compare
AayushSabharwal
force-pushed
the
as/fix-trivial-tearing
branch
from
0a7085e to
8f923c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trivial_tearing!didn't handle removing equations/variables correctly. This will enable it to do so, and provide a common API for the same. There are some follow-up changes necessary in MTKTearing, but I'll put that in a separate PR to ensure this one doesn't break things.