feat: implement new trivial_tearing! interface for MTK, update mm#56
Merged
AayushSabharwal merged 3 commits intomainfrom Mar 30, 2026
Merged
feat: implement new trivial_tearing! interface for MTK, update mm#56AayushSabharwal merged 3 commits intomainfrom
trivial_tearing! interface for MTK, update mm#56AayushSabharwal merged 3 commits intomainfrom
Conversation
AayushSabharwal
force-pushed
the
as/fix-trivial-tearing
branch
from
8595dc0 to
daeb7d7
Compare
AayushSabharwal
force-pushed
the
as/fix-trivial-tearing
branch
from
daeb7d7 to
e5eae15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new functionality added in #55. It also fixes an issue where
trivial_tearing!invalidated themmmatrix, leading to incorrect simplification in some models.trivial_tearing!can now updatemmand return it. Materializing the fix will involve calling the 2-argument method oftrivial_tearing!in MTK.