Skip to content

fix: consider model inputs for diffcache reference #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Apr 7, 2026
Merged

fix: consider model inputs for diffcache reference #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/ModelingToolkitTearing/src/reassemble.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,9 +606,14 @@ function get_linear_scc_linsol(state::TearingState, alg_eqs::Vector{Int},
else
reference = fullvars[state_idx]
end
reference_args = Symbolics.SArgsT((reference, MTKBase.get_iv(sys)::SymbolicT))
inps = MTKBase.inputs(sys)
if !isempty(inps)
push!(reference_args, first(inps))
end
reference = Symbolics.STerm(
promote, Symbolics.SArgsT((reference, MTKBase.get_iv(sys)::SymbolicT));
type = Vector{Real}, shape = [1:2]
promote, reference_args;
type = Vector{Real}, shape = [1:length(reference_args)]
)[1]
sys, A_cache = MTKBase.add_diffcache(sys, length(A))
A_allocator = A_cache(reference)
Expand Down Expand Up @@ -846,7 +851,6 @@ Solve equation `eq` for `var`, substitute previously solved variables, and retur
function make_solved_equation(var, eq, total_sub; simplify = false)
residual = eq.lhs - eq.rhs
a, b, islinear = Symbolics.linear_expansion(residual, var)
@assert islinear
# 0 ~ a * var + b
# var ~ -b/a
if SU._iszero(a)
Expand Down
Loading