Skip to content

fix: allow multiple observables to solve from the same inline linsolve index#68

Merged
AayushSabharwal merged 1 commit intomainfrom
as/fix-unhack-sys
Apr 9, 2026
Merged

fix: allow multiple observables to solve from the same inline linsolve index#68
AayushSabharwal merged 1 commit intomainfrom
as/fix-unhack-sys

Conversation

@AayushSabharwal
Copy link
Copy Markdown
Member

@AayushSabharwal AayushSabharwal commented Apr 8, 2026

The situation is that D(x) part of an inline linear SCC, so it turns into D(x) ~ linsolve(..)[i] and this goes into total_sub. Then, two observed equations are of the form

y ~ D(D(foo))
z ~ D(D(foo))

Where D(D(foo)) via total_sub resolves to D(x) and then linsolve(..)[i]. So multiple observed variables can be obtained from the same inline linear solve. This PR modifies unhack_system to handle that case.

The reproducer is from Dyad and is not something I'm able to MWE.

@baggepinnen
Copy link
Copy Markdown

once this is merged, can a release be made so that we can make a release of MBC? 🙏

@AayushSabharwal AayushSabharwal merged commit b4dbfaa into main Apr 9, 2026
11 of 23 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-unhack-sys branch April 9, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants