fix: allow multiple observables to solve from the same inline linsolve index#68
Merged
AayushSabharwal merged 1 commit intomainfrom Apr 9, 2026
Merged
fix: allow multiple observables to solve from the same inline linsolve index#68AayushSabharwal merged 1 commit intomainfrom
AayushSabharwal merged 1 commit intomainfrom
Conversation
|
once this is merged, can a release be made so that we can make a release of MBC? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The situation is that
D(x)part of an inline linear SCC, so it turns intoD(x) ~ linsolve(..)[i]and this goes intototal_sub. Then, two observed equations are of the formWhere
D(D(foo))viatotal_subresolves toD(x)and thenlinsolve(..)[i]. So multiple observed variables can be obtained from the same inline linear solve. This PR modifiesunhack_systemto handle that case.The reproducer is from Dyad and is not something I'm able to MWE.