Skip to content

fix: allow multiple observables to solve from the same inline linsolve index #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Apr 9, 2026
Merged

fix: allow multiple observables to solve from the same inline linsolve index #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions lib/ModelingToolkitTearing/src/ModelingToolkitTearing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ function MTKBase.unhack_system(sys::System)
subst = SU.Substituter{false}(additional_subs, SU.default_substitute_filter)
obseqs = obseqs[obs_mask]
map!(subst, obseqs, obseqs)
map!(subst, additional_eqs, additional_eqs)
append!(eqs, additional_eqs)
map!(subst, eqs, eqs)

if sched isa MTKBase.Schedule
map!(subst, values(sched.dummy_sub))
Expand Down Expand Up @@ -190,14 +190,7 @@ function populate_inline_scc_map!(
is_ldiv || return
len = length(ldiv)
buffer = get!(() -> zeros(Int, len), inline_linear_scc_map, ldiv)
if !iszero(buffer[idx])
is_diffeq && return
throw(ArgumentError("""
Found multiple inline linear solves solving the same variable. \
This should not be possible. Please open an issue in \
`ModelingToolkit.jl` with an MWE.
"""))
end
iszero(buffer[idx]) || return
buffer[idx] = ifelse(is_diffeq, -eq_i, eq_i)
end

Expand Down
Loading