Skip to content

refactor: use mutable cache API for unhack_system #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AayushSabharwal wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −9
Open

refactor: use mutable cache API for unhack_system #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions lib/ModelingToolkitTearing/src/ModelingToolkitTearing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,14 @@ include("reassemble.jl")

struct UnhackSystemCacheKey end

function MTKBase.should_invalidate_mutable_cache_entry(::Type{UnhackSystemCacheKey}, patch::NamedTuple)
return true
end

function MTKBase.unhack_system(sys::System)
cache = getmetadata(sys, MTKBase.MutableCacheKey, nothing)
if cache isa MTKBase.MutableCacheKey
cached_sys = get(cache, UnhackSystemCacheKey, nothing)
if cached_sys isa System
return cached_sys
end
cached_sys = MTKBase.check_mutable_cache(sys, UnhackSystemCacheKey, System, nothing)
if cached_sys isa System
return cached_sys
end
# Observed are copied by the masking operation
obseqs = observed(sys)
Expand Down Expand Up @@ -173,9 +174,7 @@ function MTKBase.unhack_system(sys::System)
@set! newsys.unknowns = dvs
@set! newsys.schedule = sched

if cache isa MTKBase.MutableCacheT
cache[UnhackSystemCacheKey] = newsys
end
MTKBase.store_to_mutable_cache!(sys, UnhackSystemCacheKey, newsys)

return newsys
end
Expand Down
Loading