Skip to content

fix: properly subset state_priorities in system_subset #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Apr 29, 2026
Merged

fix: properly subset state_priorities in system_subset #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ModelingToolkitTearing/src/clock_inference/interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ function system_subset(structure::SystemStructure, ieqs::Vector{Int}, ivars::Vec
@set! structure.graph = complete(BipartiteGraph(ne, fadj, length(ivars)))
@set! structure.eq_to_diff = eq_to_diff
@set! structure.var_to_diff = complete(var_to_diff)
@set! structure.state_priorities = structure.state_priorities[ivars]
@set! structure.var_types = structure.var_types[ivars]
structure
end

Expand Down
21 changes: 21 additions & 0 deletions lib/ModelingToolkitTearing/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,3 +169,24 @@ end
], t
) reassemble_alg = MTKTearing.DefaultReassembleAlgorithm(; inline_linear_sccs = true)
end

@testset "`system_subset(::SystemStructure)` subsets `.state_priorities`" begin
@variables x(t) y(t) [state_priority = 2] z(t) [state_priority = 5]
@named sys = System([D(x) ~ x, D(y) ~ y, D(z) ~ z], t)
ts = TearingState(sys)

# Confirm priorities are set as expected in the full structure
x_idx = findfirst(isequal(x), ts.fullvars)::Int
y_idx = findfirst(isequal(y), ts.fullvars)::Int
z_idx = findfirst(isequal(z), ts.fullvars)::Int
@test ts.structure.state_priorities[x_idx] == 0
@test ts.structure.state_priorities[y_idx] == 2
@test ts.structure.state_priorities[z_idx] == 5

# Subset to only y and z
ieqs = [𝑑neighbors(ts.structure.graph, y_idx); 𝑑neighbors(ts.structure.graph, z_idx)]
ivars = [y_idx, z_idx, ts.structure.var_to_diff[y_idx], ts.structure.var_to_diff[z_idx]]
sub = MTKTearing.system_subset(ts.structure, ieqs, ivars)
@test sub.state_priorities == [2, 5, 2, 5]
end

Loading