Bump FindFirstFunctions compat to allow 2.x#86
Merged
ChrisRackauckas merged 1 commit intoMay 21, 2026
Merged
Conversation
The new `2.x` line is API-compatible for the surface StateSelection actually uses (`findfirstequal`, with an unchanged signature). Tests pass locally against FFF 2.0.0. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
AayushSabharwal
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StateSelection currently pins
FindFirstFunctions = "1.2.0", which blocks downstream consumers from using FFF 2.0. The only FFF symbol used here isfindfirstequal(insrc/math/sparsematrixclil.jl), whose signature is unchanged between FFF 1.x and 2.0 — it remainsfindfirstequal(vpivot, ivars) -> Union{Int, Nothing}, with the sameDenseVector{Int64}fast path.This PR bumps the compat to
"1.2.0, 2".Why
FFF 2.0 added a new strategy-based API (
Auto,SearchProperties,searchsortedlast!etc.) without breaking the equality API. Downstream packages that have moved to FFF 2.0 (e.g. SciML/DataInterpolations.jl#529) cannot co-resolve with StateSelection 1.x, which blocks any docs/test build that pulls in both via ModelingToolkit.Verification
dev-installed FFF 2.0 from a local checkout.Pkg.test()passes cleanly on Julia 1.11 (bareiss,carpanzano_tearing,get_new_mmtestsets — all 13 assertions green).findfirstequaldefinition.Notes
Please ignore until reviewed by @ChrisRackauckas. Submitting from an external account; the change is mechanical and the test suite confirms compatibility.
🤖 Generated with Claude Code