fix: ensure full_var_eq_matching is consistent with var_eq_matching#87
Open
AayushSabharwal wants to merge 1 commit into
Open
fix: ensure full_var_eq_matching is consistent with var_eq_matching#87AayushSabharwal wants to merge 1 commit into
full_var_eq_matching is consistent with var_eq_matching#87AayushSabharwal wants to merge 1 commit into
Conversation
This prevents the former from referring to variables outside the SCC and fixes some very hard to find simplification issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the former from referring to variables outside the SCC and fixes some very hard to find simplification issues. Specifically fixes the problem that #82 tried to fix. Unfortunately, this behavior only reproduces with specific variable orderings on high index DAEs.