Convert small views to Static#16
Merged
DhairyaLGandhi merged 10 commits intodg/rotfrom Feb 16, 2026
Merged
Conversation
| @@ -1,4 +1,4 @@ | |||
| const FACTORIZATION_CACHE = WeakKeyDict() | |||
| const FACTORIZATION_CACHE = Dict() | |||
Member
There was a problem hiding this comment.
Purely out of curiosity, what motivated this change?
Collaborator
Author
There was a problem hiding this comment.
StaticArrays dont finalize
Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comes up frequently in Multibody. Has one TODO: we need to check if the original source gets used elsewhere, since the behaviour of mutation of memory needs to be preserved.