Added: NonLinMPC and MovingHorizonEstimator now use value_and_gradient!/jacobian! of DI.jl#197
Merged
Conversation
NonLinMPC and MovingHorizonEstimator now use value_and_jacobian! of DI.jlNonLinMPC and MovingHorizonEstimator now use value_and_gradient!/jacobian! of DI.jl
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 98.90% 98.81% -0.10%
==========================================
Files 25 25
Lines 4220 4223 +3
==========================================
- Hits 4174 4173 -1
- Misses 46 50 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
This is also more efficient in practice. With the benchmark of the inverted pendulum with btime_NMPC_track_solver_IP = median(bm) = TrialEstimate(432.509 ms)and after this improvement: btime_NMPC_track_solver_IP = median(bm) = TrialEstimate(395.618 ms) |
Member
Author
|
BTW thanks once more @gdalle for DI.jl ! I wanted to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This theoretically more efficient than calling the objective/constraint functions and
DI.jacobian!/DI.gradient!separately. ForAutoForwardDiffbackend, this feature is similar to DiffResult.jl.