Skip to content

Add window comparison plot to documentation#652

Open
thimotedupuch wants to merge 1 commit into
JuliaDSP:masterfrom
thimotedupuch:window_plot
Open

Add window comparison plot to documentation#652
thimotedupuch wants to merge 1 commit into
JuliaDSP:masterfrom
thimotedupuch:window_plot

Conversation

@thimotedupuch
Copy link
Copy Markdown

For the documentation I added a plot with the window functions as well as the frequency response, to give an overwiew of what's available.


Thank you very much,
T.D.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (77c99a2) to head (8d7af34).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          19       19           
  Lines        3279     3279           
=======================================
  Hits         3218     3218           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wheeheee
Copy link
Copy Markdown
Member

Do you have a screenshot of that part of the docs?

@thimotedupuch
Copy link
Copy Markdown
Author

thimotedupuch commented Jan 12, 2026

It should look like this, with the sharp SVG image format and without the weird resizing effect this preview on github has

final_plot

@wheeheee
Copy link
Copy Markdown
Member

Oops, I actually meant what it looked like on the docs, whether it fits in or not. I built them and had a look.
So...I think the plot looks kind of awkward just floating above all those docstrings, but it's kinda useful so that's still acceptable, I guess...

@wheeheee
Copy link
Copy Markdown
Member

Is it possible for you to make the window names on the left horizontal and in a slightly bigger font?
It would also be nice if you could add the script used to plot this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants