Render Symbols with repr in duplicate-name error message#3533
Open
LilithHafner wants to merge 3 commits into
Open
Render Symbols with repr in duplicate-name error message#3533LilithHafner wants to merge 3 commits into
Symbols with repr in duplicate-name error message#3533LilithHafner wants to merge 3 commits into
Conversation
string.(':', sym) renders symbols containing whitespace or other
non-identifier characters ambiguously (e.g. ":column name"), making
the error read like a parse error rather than naming a single Symbol.
Switch to repr, which produces ":foo" for ordinary identifiers and
Symbol("column name") for the rest, matching what one would write
in source.
bkamins
approved these changes
Apr 26, 2026
bkamins
left a comment
bkamins
left a comment
Member
There was a problem hiding this comment.
Looks good. It would be good to add a test wih string column names, but it will work OK (they will be quoted in ").
Member
|
@nalimilan - looks good? |
nalimilan
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3532
Before:
After:
Three call sites updated (
src/other/utils.jland two insrc/other/index.jl); no tests pin the existing error string, and the docstring example inabstractdataframe.jluses:a, which still renders identically.