Skip to content

Wrap result of tracktime in a struct#142

Open
andreasnoack wants to merge 1 commit into
masterfrom
anj/tracktime
Open

Wrap result of tracktime in a struct#142
andreasnoack wants to merge 1 commit into
masterfrom
anj/tracktime

Conversation

@andreasnoack

Copy link
Copy Markdown
Member

Possible fix of #140

@codecov-io

codecov-io commented Feb 26, 2018

Copy link
Copy Markdown

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   59.93%   59.93%           
=======================================
  Files          18       18           
  Lines        1258     1258           
=======================================
  Hits          754      754           
  Misses        504      504
Impacted Files Coverage Δ
src/diagnostics.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4831d...b78440f. Read the comment docs.

Comment thread src/ml.jl Outdated
delayedmap(x -> schema(x, $T), xs.chunks)))
end
end

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I'd forgotten that I had that one floating around. It doesn't belong here but there is (maybe was) actually an ambiguity when I tried to using schema in the distributed case.

and avoid unconditional printing of timing results
Comment thread src/diagnostics.jl
end

struct TrackTime
obj

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually an NDSparse object -- this is quite useful to filter timings for specific steps (e.g. comm / compute) or specific processes. It would be nice to make a note of how to get to this in the printing? Once taken out, the NDSparse has to be wrapped again in this type to display as it does...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants