Skip to content

Fix compatibility with Julia 1.13+ memhash removal#97

Merged
quinnj merged 2 commits intoJuliaData:mainfrom
vtjnash:fix-memhash-compat
Apr 23, 2026
Merged

Fix compatibility with Julia 1.13+ memhash removal#97
quinnj merged 2 commits intoJuliaData:mainfrom
vtjnash:fix-memhash-compat

Conversation

@vtjnash
Copy link
Copy Markdown
Contributor

@vtjnash vtjnash commented Oct 3, 2025

Remove hash method definition when Base.memhash is not available.
On Julia 1.13+, these AbstractString types will use the default
AbstractString hash implementation which is now efficient and
zero-copy based on codeunit/iterate.

For Julia <1.13, continue using the memhash-based implementation
for compatibility.

Related to JuliaLang/julia#59697

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

Remove hash method definition when Base.memhash is not available.
On Julia 1.13+, these AbstractString types will use the default
AbstractString hash implementation which is now efficient and
zero-copy based on codeunit/iterate.

For Julia <1.13, continue using the memhash-based implementation
for compatibility.

Related to JuliaLang/julia#59697

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vtjnash vtjnash closed this Feb 14, 2026
@vtjnash vtjnash reopened this Feb 14, 2026
@vtjnash
Copy link
Copy Markdown
Contributor Author

vtjnash commented Feb 14, 2026

bump? doesn't really matter to me if you make a release, just merging to get it out of my commit list would be nice (looks like you can add dependabot.yml too if you want CI healthy again)

$ less .github/dependabot.yml 

version: 2
updates:
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "monthly"
    open-pull-requests-limit: 99
    labels:
      - "dependencies"
      - "github-actions"

Cover the remaining nightly compatibility gap in WeakRefString hashing.

- keep the old memhash fast path only when both Base hooks still exist
- add a safe fallback hash for newer Julia versions and regressions for it
- update actions/cache to v4 so GitHub Actions runs again
- bump the project version to 1.4.3 for the release cut
@quinnj quinnj merged commit 56d249b into JuliaData:main Apr 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants