allows large databases using Csize_t instead Cuint for :MapSize; fixe…#40
Closed
sadit wants to merge 1 commit into
Closed
allows large databases using Csize_t instead Cuint for :MapSize; fixe…#40sadit wants to merge 1 commit into
sadit wants to merge 1 commit into
Conversation
meggart
reviewed
Aug 12, 2024
meggart
left a comment
meggart
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for the PR
| **Note:** Consult LMDB documentation for particular values of environment parameters and flags. | ||
| """ | ||
| function setindex!(env::Environment, val::Cuint, option::Symbol) | ||
| function setindex!(env::Environment, val::Int, option::Symbol) |
Collaborator
There was a problem hiding this comment.
Should we use val::Integer instead to avoid breaking existing code
maleadt
added a commit
to maleadt/LMDB.jl
that referenced
this pull request
May 1, 2026
Fixes upstream issue JuliaDatabases#38, PR JuliaDatabases#37, PR JuliaDatabases#40: setindex! went through Cuint which silently truncated map sizes that didn't fit in 32 bits.
Collaborator
|
Superseded by 1de1895 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows large databases using Csize_t instead Cuint for :MapSize; fixes some typos