Address uniqueness, ordering, properties#151
Conversation
|
I don't have well thought out opinions about most of what's added here, but the global dict type override looks risky to me. It can change the behaviour of a program in areas far removed from where it's set, which is only safe if you own and control all the code you're running, and even then it's hairy when things scale. What's the motivation for having that a global setting, rather than passing in the dict type where you need it to be specific non-standard type? |
|
I didn't want the PR to be breaking but I also wanted to offer a short syntax for returning OrderedDicts. If you accept a breaking PR, my preferred solution would be to default to |
|
Another question is whether we accept that document["key"] doesn't retrieve the last index. Otherwise we could fix that as well. |
This PR relates to #150 and to #146